chrome/browser/ui/tabs/tab_strip_model.cc - Issue 23835007: DevTools: Do not close devtools if there are dirty files in workspace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_strip_model.cc

Issue 23835007: DevTools: Do not close devtools if there are dirty files in workspace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressing final Jeremy's comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tabs/tab_strip_model.cc

diff --git a/chrome/browser/ui/tabs/tab_strip_model.cc b/chrome/browser/ui/tabs/tab_strip_model.cc

index 91042c7a0a60a40aaed18397615fa5422c8fd6fb..a6c2c7a36b570823cb5b03f2856dd54068c10a16 100644

--- a/chrome/browser/ui/tabs/tab_strip_model.cc

+++ b/chrome/browser/ui/tabs/tab_strip_model.cc

@@ -1202,6 +1202,8 @@ bool TabStripModel::InternalCloseTabs(const std::vector<int>& indices,

std::map<content::RenderProcessHost*, size_t> processes;

for (size_t i = 0; i < indices.size(); ++i) {

WebContents* closing_contents = GetWebContentsAtImpl(indices[i]);

+ if (delegate_->ShouldRunUnloadListenerBeforeClosing(closing_contents))

+ continue;

content::RenderProcessHost* process =

closing_contents->GetRenderProcessHost();

++processes[process];