DevTools: Do not close devtools if there are dirty files in workspace

chrome/browser/devtools/devtools_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "chrome/browser/devtools/devtools_window.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
@@ skipping 562 matching lines @@
     CreateDevToolsBrowser();
 
   if (should_show_window) {
     browser_->window()->Show();
     web_contents_->GetView()->SetInitialFocus();
   }
 
   ScheduleAction(action);
 }
 
+// static
+bool DevToolsWindow::HandleBeforeUnload(content::WebContents* frontend_contents,
+    bool proceed, bool* proceed_to_fire_unload) {
+  DevToolsWindow* window = AsDevToolsWindow(
+      frontend_contents->GetRenderViewHost());
+  DCHECK(window);
+  if (!window->inspected_page_is_closing_)
+    return false;
+  window->BeforeUnloadFired(frontend_contents, proceed,
+      proceed_to_fire_unload);
+  return true;
+}
+
+// static
+bool DevToolsWindow::InterceptPageBeforeUnload(content::WebContents* contents) {
+  DevToolsWindow* window =
+      DevToolsWindow::GetInstanceForInspectedRenderViewHost(
+          contents->GetRenderViewHost());
+  if (!window || window->inspected_page_is_closing_)
+    return false;
+
+  window->inspected_page_is_closing_ = true;
+  // Handling devtools on devtools case.

[jeremy, 2013/11/13 10:52:34]

// Handle case of DevTools inspecting another DevTools instance by passing the
call down to the DevTools instance being inspected.

[lushnikov, 2013/11/13 13:39:08]

Done.

+  if (!DevToolsWindow::InterceptPageBeforeUnload(window->web_contents())) {
+    window->web_contents()->GetRenderViewHost()->FirePageBeforeUnload(false);
+  }
+  return true;
+}
+
+// static
+bool DevToolsWindow::NeedsToInterceptBeforeUnload(
+    content::WebContents* contents) {
+  DevToolsWindow* window =
+      DevToolsWindow::GetInstanceForInspectedRenderViewHost(
+          contents->GetRenderViewHost());
+  return window && !window->inspected_page_is_closing_;
+}
+
+// static
+bool DevToolsWindow::HasFiredBeforeUnloadEventForDevToolsBrowser(
+    Browser* browser) {
+  DCHECK(browser->is_devtools());
+  if (browser->tab_strip_model()->empty())

[jeremy, 2013/11/13 10:52:34]

// When FastUnloadController is used, we may detached from the browser window at
this point which means we've already fired beforeunload.

[lushnikov, 2013/11/13 13:39:08]

Done.

+    return true;
+  content::WebContents* contents =
+      browser->tab_strip_model()->GetWebContentsAt(0);
+  DevToolsWindow* window = AsDevToolsWindow(contents->GetRenderViewHost());
+  DCHECK(window);
+  return window->inspected_page_is_closing_;
+}
+
+// static
+void DevToolsWindow::OnPageCloseCanceled(content::WebContents* contents) {
+  DevToolsWindow *window =
+      DevToolsWindow::GetInstanceForInspectedRenderViewHost(
+          contents->GetRenderViewHost());
+  if (!window)
+    return;
+  window->inspected_page_is_closing_ = false;
+  // Propagate to DevTools opened on DevTools if any.
+  DevToolsWindow::OnPageCloseCanceled(window->web_contents());
+}
+
+void DevToolsWindow::SetDockSideForTest(DevToolsDockSide dock_side) {
+  SetDockSide(SideToString(dock_side));
+}
+
 DevToolsWindow::DevToolsWindow(Profile* profile,
                                const GURL& url,
                                content::RenderViewHost* inspected_rvh,
                                DevToolsDockSide dock_side)
     : profile_(profile),
       browser_(NULL),
       dock_side_(dock_side),
       is_loaded_(false),
       action_on_load_(DevToolsToggleAction::Show()),
       width_(-1),
       height_(-1),
       dock_side_before_minimized_(dock_side),
+      inspected_page_is_closing_(false),
       weak_factory_(this) {
   web_contents_ =
       content::WebContents::Create(content::WebContents::CreateParams(profile));
   frontend_contents_observer_.reset(new FrontendWebContentsObserver(this));
 
   web_contents_->GetController().LoadURL(url, content::Referrer(),
       content::PAGE_TRANSITION_AUTO_TOPLEVEL, EmptyString());
 
   frontend_host_.reset(content::DevToolsClientHost::CreateDevToolsFrontendHost(
       web_contents_, this));
@@ skipping 201 matching lines @@
     inspected_window->UpdateDevTools();
   // In case of docked web_contents_, we own it so delete here.
   // Embedding DevTools window will be deleted as a result of
   // WebContentsDestroyed callback.
   delete web_contents_;
 }
 
 void DevToolsWindow::BeforeUnloadFired(content::WebContents* tab,
                                        bool proceed,
                                        bool* proceed_to_fire_unload) {
-  if (proceed) {
-    content::DevToolsManager::GetInstance()->ClientHostClosing(
-        frontend_host_.get());
+  if (!inspected_page_is_closing_) {

[jeremy, 2013/11/13 10:52:34]

// Docked devtools window closed directly.

[lushnikov, 2013/11/13 13:39:08]

Done.

+    if (proceed) {
+      content::DevToolsManager::GetInstance()->ClientHostClosing(
+          frontend_host_.get());
+    }
+    *proceed_to_fire_unload = proceed;
+  } else {

[jeremy, 2013/11/13 10:52:34]

Closing as result of event from devtools content.

[lushnikov, 2013/11/13 13:39:08]

Reworded, done.

+    content::WebContents* inspected_web_contents = GetInspectedWebContents();
+    if (proceed) {
+      inspected_web_contents->GetRenderViewHost()->FirePageBeforeUnload(false);
+    } else {
+      bool should_proceed;
+      inspected_web_contents->GetDelegate()->BeforeUnloadFired(
+          inspected_web_contents, false, &should_proceed);
+      DCHECK(!should_proceed);
+    }
+    *proceed_to_fire_unload = false;
   }
-  *proceed_to_fire_unload = proceed;
 }
 
 bool DevToolsWindow::PreHandleKeyboardEvent(
     content::WebContents* source,
     const content::NativeWebKeyboardEvent& event,
     bool* is_keyboard_shortcut) {
   if (IsDocked()) {
     BrowserWindow* inspected_window = GetInspectedBrowserWindow();
     if (inspected_window) {
       return inspected_window->PreHandleKeyboardEvent(event,
@@ skipping 583 matching lines @@
   return inspected_contents_observer_ ?
       inspected_contents_observer_->web_contents() : NULL;
 }
 
 void DevToolsWindow::DocumentOnLoadCompletedInMainFrame() {
   is_loaded_ = true;
   UpdateTheme();
   DoAction();
   AddDevToolsExtensionsToClient();
 }