Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 23835002: [NaCl docs] Initial commit of the new docs infrastructure into Chromium. (Closed)

Created:
7 years, 3 months ago by eliben
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, binji, Sam Clegg, extensions-reviews_chromium.org
Visibility:
Public.

Description

[NaCl docs] Initial commit of the new docs infrastructure into Chromium. This reflects the current state of master in https://github.com/eliben/nacl-docs-rst BUG=None R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220672

Patch Set 1 #

Total comments: 6

Patch Set 2 : Ben's review #

Patch Set 3 : Try to appease pylint #

Patch Set 4 : Ignore Sphinx-y code in presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2706 lines, -0 lines) Patch
M native_client_sdk/PRESUBMIT.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A native_client_sdk/src/doc/.gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/Makefile View 1 chunk +185 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/README View 1 chunk +64 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/_sphinxext/devsite_builder.py View 1 2 1 chunk +286 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/_static/css/local_extensions.css View 1 chunk +352 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/conf.py View 1 2 1 chunk +168 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/devguide/coding/application-structure.rst View 1 chunk +8 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/devguide/devcycle/building.rst View 1 chunk +8 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/devguide/distributing.rst View 1 chunk +497 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/devguide/index.rst View 1 chunk +8 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/devguide/tutorial.rst View 1 chunk +8 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/images/3d-graphics-render-loop.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/NaClExecution.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/NaclBlock.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/ProgramStructure.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/bradchen.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/check-red.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/extensions-management.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/fileioexample.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/gear-icon.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/medal-64_1st.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/medal-64_2nd.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/medal-64_3rd.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/medal-64_4th.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/menu-icon.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/naclmounts1.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/new-tab-apps.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/pepper.jpg View Binary file 0 comments Download
A native_client_sdk/src/doc/images/pepper-audio-api.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/pepper-audio-buffer.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/pepper-fileiocreate.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/pepper-fileioread.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/pepper-urlloader-api.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/postmessage.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/postmessage2.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/puzzle.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/visualstudio1.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/visualstudio2.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/visualstudio4.png View Binary file 0 comments Download
A native_client_sdk/src/doc/images/wrenchTool.png View Binary file 0 comments Download
A native_client_sdk/src/doc/index.rst View 1 chunk +21 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/overview.rst View 1 chunk +385 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/quick-start.rst View 1 chunk +27 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/rest-devsite-examples.rst View 1 chunk +208 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/sdk/download.rst View 1 chunk +221 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/sdk/examples.rst View 1 chunk +249 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/sdk/release-notes.rst View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eliben
7 years, 3 months ago (2013-08-30 20:09:52 UTC) #1
binji
lgtm https://codereview.chromium.org/23835002/diff/1/native_client_sdk/src/doc/_static/css/local_extensions.css File native_client_sdk/src/doc/_static/css/local_extensions.css (right): https://codereview.chromium.org/23835002/diff/1/native_client_sdk/src/doc/_static/css/local_extensions.css#newcode1 native_client_sdk/src/doc/_static/css/local_extensions.css:1: /* ======================== */ can you explain the purpose ...
7 years, 3 months ago (2013-08-30 20:51:19 UTC) #2
eliben
https://codereview.chromium.org/23835002/diff/1/native_client_sdk/src/doc/_static/css/local_extensions.css File native_client_sdk/src/doc/_static/css/local_extensions.css (right): https://codereview.chromium.org/23835002/diff/1/native_client_sdk/src/doc/_static/css/local_extensions.css#newcode1 native_client_sdk/src/doc/_static/css/local_extensions.css:1: /* ======================== */ On 2013/08/30 20:51:20, binji wrote: > ...
7 years, 3 months ago (2013-08-30 20:55:34 UTC) #3
eliben
7 years, 3 months ago (2013-08-30 22:00:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r220672 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698