Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2383473004: Remove PrintingContext::InitWithSettings(). (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
dpapad
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PrintingContext::InitWithSettings(). It is unused on many platforms. Keep it in the implementations on platforms that do use it. Committed: https://crrev.com/5f68391da92d37903561f1e0bee178b242d93daf Cr-Commit-Position: refs/heads/master@{#422250}

Patch Set 1 #

Patch Set 2 : rebase, fix build #

Patch Set 3 : fix build #

Patch Set 4 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -103 lines) Patch
M printing/emf_win_unittest.cc View 1 2 3 9 chunks +17 lines, -15 lines 0 comments Download
M printing/printing_context.h View 1 chunk +0 lines, -3 lines 0 comments Download
M printing/printing_context_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M printing/printing_context_android.cc View 5 chunks +14 lines, -28 lines 0 comments Download
M printing/printing_context_chromeos.h View 1 chunk +0 lines, -1 line 0 comments Download
M printing/printing_context_chromeos.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M printing/printing_context_linux.h View 2 chunks +3 lines, -1 line 0 comments Download
M printing/printing_context_linux.cc View 1 chunk +1 line, -4 lines 0 comments Download
M printing/printing_context_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M printing/printing_context_mac.mm View 1 chunk +0 lines, -11 lines 0 comments Download
M printing/printing_context_no_system_dialog.h View 1 chunk +0 lines, -1 line 0 comments Download
M printing/printing_context_no_system_dialog.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M printing/printing_context_win.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M printing/printing_context_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_win_unittest.cc View 1 2 7 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
Lei Zhang
4 years, 2 months ago (2016-09-30 21:13:13 UTC) #18
dpapad
lgtm
4 years, 2 months ago (2016-09-30 22:19:15 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383473004/60001
4 years, 2 months ago (2016-09-30 22:36:41 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-30 22:42:38 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 22:44:28 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5f68391da92d37903561f1e0bee178b242d93daf
Cr-Commit-Position: refs/heads/master@{#422250}

Powered by Google App Engine
This is Rietveld 408576698