Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2383473003: [stubs] Add more helper methods for heap constants (Closed)

Created:
4 years, 2 months ago by Camillo Bruni
Modified:
4 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Add more helper methods for heap constants Committed: https://crrev.com/5420ae516ee8332b7620ad42a3beaf194a6d7e08 Cr-Commit-Position: refs/heads/master@{#39902}

Patch Set 1 #

Patch Set 2 : formatting #

Total comments: 1

Patch Set 3 : addressing nits #

Patch Set 4 : rebasing onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -120 lines) Patch
M src/code-stub-assembler.h View 1 2 3 2 chunks +22 lines, -11 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 3 1 chunk +12 lines, -42 lines 0 comments Download
M src/code-stubs.cc View 1 22 chunks +33 lines, -67 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Camillo Bruni
PTAL. Maybe we need the *Constant suffix for the IsXXX test functions as well to ...
4 years, 2 months ago (2016-09-29 12:55:02 UTC) #2
Camillo Bruni
PTAL
4 years, 2 months ago (2016-09-29 13:24:41 UTC) #5
Igor Sheludko
lgtm with a nit. I also updated the CL's description. https://codereview.chromium.org/2383473003/diff/20001/src/code-stub-assembler.cc File src/code-stub-assembler.cc (right): https://codereview.chromium.org/2383473003/diff/20001/src/code-stub-assembler.cc#newcode46 ...
4 years, 2 months ago (2016-09-29 13:54:53 UTC) #7
Igor Sheludko
lgtm with a nit. I also updated the CL's description.
4 years, 2 months ago (2016-09-29 13:54:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383473003/40001
4 years, 2 months ago (2016-09-29 14:41:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9936)
4 years, 2 months ago (2016-09-29 14:43:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383473003/60001
4 years, 2 months ago (2016-09-30 07:47:18 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-30 08:13:21 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 08:13:57 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5420ae516ee8332b7620ad42a3beaf194a6d7e08
Cr-Commit-Position: refs/heads/master@{#39902}

Powered by Google App Engine
This is Rietveld 408576698