[stubs] Add more helper methods for heap constants

[stubs] Add more helper methods for heap constants

Committed: https://crrev.com/5420ae516ee8332b7620ad42a3beaf194a6d7e08
Cr-Commit-Position: refs/heads/master@{#39902}

[Camillo Bruni, 2016-09-29 12:55:02]

cbruni@chromium.org changed reviewers:
+ jarin@chromium.org

[Camillo Bruni, 2016-09-29 12:55:02]

PTAL.
Maybe we need the *Constant suffix for the IsXXX test functions as well to be
more consistent.

[Jarin, 2016-09-29 13:18:44]

Description was changed from

==========
[code-stubs] Addd more helper methods for heap constants

BUG=
==========

to

==========
[code-stubs] Addd more helper methods for heap constants

BUG=
==========

[Jarin, 2016-09-29 13:18:44]

jarin@chromium.org changed reviewers:
+ ishell@chromium.org
- jarin@chromium.org

[Camillo Bruni, 2016-09-29 13:24:41]

PTAL

[Igor Sheludko, 2016-09-29 13:40:02]

Description was changed from

==========
[code-stubs] Addd more helper methods for heap constants

BUG=
==========

to

==========
[stubs] Add more helper methods for heap constants
==========

[Igor Sheludko, 2016-09-29 13:54:53]

lgtm with a nit.

I also updated the CL's description.

https://codereview.chromium.org/2383473003/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2383473003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:46: return
HeapConstant(isolate()->factory()->boolean_map());
Why is boolean_map so different? I guess 
  V(boolean_map, BooleanMap)                \
will do the trick.

[Igor Sheludko, 2016-09-29 13:54:56]

lgtm with a nit.

I also updated the CL's description.

[Camillo Bruni, 2016-09-29 14:41:53]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-09-29 14:41:54]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2383473003/#ps40001
(title: "addressing nits")

[commit-bot: I haz the power, 2016-09-29 14:41:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 14:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 14:43:52]

Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9936)

[Camillo Bruni, 2016-09-30 07:47:07]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-09-30 07:47:08]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2383473003/#ps60001
(title: "rebasing onto master")

[commit-bot: I haz the power, 2016-09-30 07:47:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 08:13:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-30 08:13:56]

Description was changed from

==========
[stubs] Add more helper methods for heap constants
==========

to

==========
[stubs] Add more helper methods for heap constants

Committed: https://crrev.com/5420ae516ee8332b7620ad42a3beaf194a6d7e08
Cr-Commit-Position: refs/heads/master@{#39902}
==========

[commit-bot: I haz the power, 2016-09-30 08:13:57]

Patchset 4 (id:??) landed as
https://crrev.com/5420ae516ee8332b7620ad42a3beaf194a6d7e08
Cr-Commit-Position: refs/heads/master@{#39902}