Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2126)

Unified Diff: cc/test/ordered_simple_task_runner.cc

Issue 2383473002: [scheduler] Teach scheduler about audio state (Closed)
Patch Set: Switched approach to use WebContentsImpl::WasRecentlyAudible Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/ordered_simple_task_runner.cc
diff --git a/cc/test/ordered_simple_task_runner.cc b/cc/test/ordered_simple_task_runner.cc
index a3d66ee6d3a58510e49557842b0498955f17fc83..a0271b0c19126055ad9e2610056f58703f9821a3 100644
--- a/cc/test/ordered_simple_task_runner.cc
+++ b/cc/test/ordered_simple_task_runner.cc
@@ -249,7 +249,7 @@ bool OrderedSimpleTaskRunner::RunUntilTime(base::TimeTicks time) {
// If the next task is after the stopping time and auto-advancing now, then
// force time to be the stopping time.
- if (!result && advance_now_ && now_src_->NowTicks() < time) {
+ if (advance_now_ && now_src_->NowTicks() < time) {
Sami 2016/10/03 14:37:30 Not sure why this change is needed?
altimin 2016/10/03 15:53:38 tl;dr: Without this change new test does not work
Sami 2016/10/03 16:25:29 Yeah okay, I think it seems a little weird to not
altimin 2016/10/03 16:28:22 It kinda makes sense: please take a look at RunUnt
now_src_->Advance(time - now_src_->NowTicks());
}

Powered by Google App Engine
This is Rietveld 408576698