Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h

Issue 2383473002: [scheduler] Teach scheduler about audio state (Closed)
Patch Set: Reverted DEPS Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h b/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
index 5b249c76f3fe12d1aa0ca0d09968a7c4cfd86c4a..df2635446829384600aa7aebc5b07a3ddeb73032 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
@@ -162,7 +162,13 @@ class BLINK_PLATFORM_EXPORT TaskQueueThrottler : public TimeDomain::Observer {
// Tells the TaskQueueThrottler we're using virtual time, which disables all
alex clarke (OOO till 29th) 2016/09/30 10:33:46 Remove out of date comment.
altimin 2016/10/03 11:15:26 Done.
// throttling.
- void EnableVirtualTime();
+ // Disable throttling for all queues, this setting takes precedence over
+ // all other throttling settings. Designed to be used when a global event
+ // disabling throttling happens (e.g. audio is playing).
+ void DisableThrottling();
Sami 2016/09/30 11:52:09 These two need a unit test or a couple I think.
altimin 2016/10/03 11:15:25 Done.
+
+ // Enable back global throttling.
+ void EnableThrottling();
const ThrottledTimeDomain* time_domain() const { return time_domain_.get(); }
@@ -236,7 +242,7 @@ class BLINK_PLATFORM_EXPORT TaskQueueThrottler : public TimeDomain::Observer {
CancelableClosureHolder pump_throttled_tasks_closure_;
base::Optional<base::TimeTicks> pending_pump_throttled_tasks_runtime_;
- bool virtual_time_;
+ bool allow_throttling_;
std::unordered_map<TimeBudgetPool*, std::unique_ptr<TimeBudgetPool>>
time_budget_pools_;

Powered by Google App Engine
This is Rietveld 408576698