content/common/page_messages.h - Issue 2383473002: [scheduler] Teach scheduler about audio state

Side by Side Diff: content/common/page_messages.h

Issue 2383473002: [scheduler] Teach scheduler about audio state (Closed)

Patch Set: Rebased Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents.h » ('j') | content/public/browser/web_contents.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/common/page_message_enums.h"	5 #include "content/common/page_message_enums.h"

6 #include "ipc/ipc_message_macros.h"	6 #include "ipc/ipc_message_macros.h"

7 #include "ui/gfx/geometry/rect.h"	7 #include "ui/gfx/geometry/rect.h"

8	8

9 // IPC messages for page-level actions.	9 // IPC messages for page-level actions.

10 // Multiply-included message file, hence no include guard.	10 // Multiply-included message file, hence no include guard.

(...skipping 25 matching lines...) Expand all Loading...
36 // Informs the renderer that the page is no longer hidden.	36 // Informs the renderer that the page is no longer hidden.

37 IPC_MESSAGE_ROUTED0(PageMsg_WasShown)	37 IPC_MESSAGE_ROUTED0(PageMsg_WasShown)

38	38

39 // Sent when the history for this page is altered from another process. The	39 // Sent when the history for this page is altered from another process. The

40 // history list should be reset to \|history_length\| length, and the offset	40 // history list should be reset to \|history_length\| length, and the offset

41 // should be reset to \|history_offset\|.	41 // should be reset to \|history_offset\|.

42 IPC_MESSAGE_ROUTED2(PageMsg_SetHistoryOffsetAndLength,	42 IPC_MESSAGE_ROUTED2(PageMsg_SetHistoryOffsetAndLength,

43 int /* history_offset */,	43 int /* history_offset */,

44 int /* history_length */)	44 int /* history_length */)

45	45

	46 IPC_MESSAGE_ROUTED1(PageMsg_AudioStateChanged, bool /* is_audio_playing */)
	miu 2016/11/15 22:04:04 OOC, why are we doing this whole "round about" app OOC, why are we doing this whole "round about" approach: send sound to the browser process, then have it do audible detection (takes time), and finally send the renderer back a message to determine whether it should disable throttling? Instead, it seems like anything that causes audio to be generated should directly call DisableThrottling() (e.g., from HTMLMediaElement.cpp, the WebAudio modules, etc.). Then, correct behavior would not be dependent on the browser process. altimin 2016/11/16 12:22:32 Because we do not want to disable throttling when Show quoted text On 2016/11/15 22:04:04, miu wrote: > OOC, why are we doing this whole "round about" approach: send sound to the > browser process, then have it do audible detection (takes time), and finally > send the renderer back a message to determine whether it should disable > throttling? > > Instead, it seems like anything that causes audio to be generated should > directly call DisableThrottling() (e.g., from HTMLMediaElement.cpp, the WebAudio > modules, etc.). Then, correct behavior would not be dependent on the browser > process. Because we do not want to disable throttling when page is not audible. Also this approach makes easy to explain when we avoid throttling -- the rules are the same as for displaying sound notification in browser UI. (Also controlling scheduler settings is not uncommon - for example, foreground/background page stage is forwarded to the scheduler via browser process). If you have further questions, let's continue discussion in crrev.com/2496173003.
	47

46 // -----------------------------------------------------------------------------	48 // -----------------------------------------------------------------------------

47 // Messages sent from the renderer to the browser.	49 // Messages sent from the renderer to the browser.

48	50

49 // Adding a new message? Stick to the sort order above: first platform	51 // Adding a new message? Stick to the sort order above: first platform

50 // independent PageMsg, then ifdefs for platform specific PageMsg, then platform	52 // independent PageMsg, then ifdefs for platform specific PageMsg, then platform

51 // independent PageHostMsg, then ifdefs for platform specific PageHostMsg.	53 // independent PageHostMsg, then ifdefs for platform specific PageHostMsg.

OLD	NEW