Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2383463002: [wasm] Rename encoder.(cc,h) to wasm-module-builder.(cc,h) (Closed)

Created:
4 years, 2 months ago by titzer
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Rename encoder.(cc,h) to wasm-module-builder.(cc,h) R=bradnelson@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org BUG= Committed: https://crrev.com/c1e320b0747addd2877d5c80b5ff52acdea84a69 Cr-Commit-Position: refs/heads/master@{#39861}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -772 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M src/asmjs/asm-js.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/asmjs/asm-wasm-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
D src/wasm/encoder.h View 1 chunk +0 lines, -264 lines 0 comments Download
D src/wasm/encoder.cc View 1 chunk +0 lines, -453 lines 0 comments Download
M src/wasm/wasm-js.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + src/wasm/wasm-module-builder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/wasm/wasm-module-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/fuzzer/wasm-code.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/fuzzer/wasm-section-fuzzers.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -1 line 0 comments Download
D test/unittests/wasm/encoder-unittest.cc View 1 chunk +0 lines, -36 lines 0 comments Download
A + test/unittests/wasm/wasm-module-builder-unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
titzer
4 years, 2 months ago (2016-09-29 08:50:15 UTC) #1
Michael Starzinger
LGTM (rubber-stamp, just one nit). https://codereview.chromium.org/2383463002/diff/1/test/unittests/wasm/wasm-module-builder-unittest.cc File test/unittests/wasm/wasm-module-builder-unittest.cc (right): https://codereview.chromium.org/2383463002/diff/1/test/unittests/wasm/wasm-module-builder-unittest.cc#newcode18 test/unittests/wasm/wasm-module-builder-unittest.cc:18: class EncoderTest : public ...
4 years, 2 months ago (2016-09-29 09:08:56 UTC) #4
titzer
On 2016/09/29 09:08:56, Michael Starzinger wrote: > LGTM (rubber-stamp, just one nit). > > https://codereview.chromium.org/2383463002/diff/1/test/unittests/wasm/wasm-module-builder-unittest.cc ...
4 years, 2 months ago (2016-09-29 10:53:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383463002/20001
4 years, 2 months ago (2016-09-29 11:26:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 11:29:12 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 11:29:28 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c1e320b0747addd2877d5c80b5ff52acdea84a69
Cr-Commit-Position: refs/heads/master@{#39861}

Powered by Google App Engine
This is Rietveld 408576698