Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 2383443002: Revert of [heap] Remove border page (Closed)

Created:
4 years, 2 months ago by Michael Lippautz
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Remove border page Reason for revert: No real improvement as we still lack the ability to promote from scavenges/young gen GCs. Let's keep this in mind for later. Original issue's description: > [heap] Remove border page > > A page now belongs either the nursery *or* the intermediate gen. The page that > contained objects of both spaces is removed in this change. > > BUG=chromium:636331 > > Committed: https://crrev.com/42ece47446f0dbd3779d6e0e00dce97a1931a9f9 > Cr-Commit-Position: refs/heads/master@{#39778} TBR=ulan@chromium.org,hpayer@chromium.org BUG=chromium:636331 Committed: https://crrev.com/9af3142fbadfe99e53c378dbe6e363e17aed89af Cr-Commit-Position: refs/heads/master@{#39854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -109 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/heap/heap-inl.h View 3 chunks +15 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M src/heap/spaces.h View 11 chunks +51 lines, -24 lines 0 comments Download
M src/heap/spaces.cc View 6 chunks +14 lines, -44 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +0 lines, -16 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383443002/1
4 years, 2 months ago (2016-09-29 08:37:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 09:20:54 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 09:21:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9af3142fbadfe99e53c378dbe6e363e17aed89af
Cr-Commit-Position: refs/heads/master@{#39854}

Powered by Google App Engine
This is Rietveld 408576698