Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: public/platform/WebLayer.h

Issue 23834010: Change WebLayer::addAnimation to transfer ownership of WebAnimation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Pass ownership of WebAnimation under ANIMATION_OWNERSHIP_NOT_TRANSFER guard. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebLayer.h
diff --git a/public/platform/WebLayer.h b/public/platform/WebLayer.h
index 67312e0a736324d3ac7fec063647e0efee99d8b1..ba39d6b2fddd8ce0a59164da1851429299f83e39 100644
--- a/public/platform/WebLayer.h
+++ b/public/platform/WebLayer.h
@@ -136,7 +136,12 @@ public:
// deleting the delegate.
virtual void setAnimationDelegate(WebAnimationDelegate*) = 0;
+ // TODO(dshwang): temporary macro to change addAnimation() in both Blink and Chromium.
+#define ANIMATION_OWNERSHIP_NOT_TRANSFER
+
// Returns false if the animation cannot be added.
+ // It passes ownership of WebAnimation to Chromium.
+ // NOTE: Chromium owns the WebAnimation pointer.
virtual bool addAnimation(WebAnimation*) = 0;
// Removes all animations with the given id.
« Source/core/platform/graphics/GraphicsLayer.cpp ('K') | « Source/web/LinkHighlight.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698