Source/web/LinkHighlight.h - Issue 23834010: Change WebLayer::addAnimation to transfer ownership of WebAnimation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/LinkHighlight.h

Issue 23834010: Change WebLayer::addAnimation to transfer ownership of WebAnimation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change GraphicsLayer and LinkHighlight to clarify ownership transfer Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
80 void clearGraphicsLayerLinkHighlightPointer();	80 void clearGraphicsLayerLinkHighlightPointer();

81 // This function computes the highlight path, and returns true if it has cha nged	81 // This function computes the highlight path, and returns true if it has cha nged

82 // size since the last call to this function.	82 // size since the last call to this function.

83 bool computeHighlightLayerPathAndPosition(WebCore::RenderLayer*);	83 bool computeHighlightLayerPathAndPosition(WebCore::RenderLayer*);

84	84

85 OwnPtr<WebContentLayer> m_contentLayer;	85 OwnPtr<WebContentLayer> m_contentLayer;

86 OwnPtr<WebLayer> m_clipLayer;	86 OwnPtr<WebLayer> m_clipLayer;

87 WebCore::Path m_path;	87 WebCore::Path m_path;

88	88

89 RefPtr<WebCore::Node> m_node;	89 RefPtr<WebCore::Node> m_node;

90 OwnPtr<WebAnimation> m_animation;

91 WebViewImpl* m_owningWebViewImpl;	90 WebViewImpl* m_owningWebViewImpl;

92 WebCore::GraphicsLayer* m_currentGraphicsLayer;	91 WebCore::GraphicsLayer* m_currentGraphicsLayer;

93	92

94 bool m_geometryNeedsUpdate;	93 bool m_geometryNeedsUpdate;

95 bool m_isAnimating;	94 bool m_isAnimating;

96 double m_startTime;	95 double m_startTime;

97 };	96 };

98	97

99 } // namespace WebKit	98 } // namespace WebKit

100	99

101 #endif	100 #endif

OLD	NEW

« Source/core/rendering/RenderLayerBacking.cpp ('K') | « Source/core/rendering/RenderLayerBacking.cpp ('k') | Source/web/LinkHighlight.cpp » ('j') | Source/web/LinkHighlight.cpp » ('J')