Change WebLayer::addAnimation to transfer ownership of WebAnimation.

Source/core/platform/graphics/GraphicsLayer.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 951 matching lines @@
 void GraphicsLayer::setContentsToCanvas(WebLayer* layer)
 {
     setContentsTo(ContentsLayerForCanvas, layer);
 }
 
 void GraphicsLayer::setContentsToMedia(WebLayer* layer)
 {
     setContentsTo(ContentsLayerForVideo, layer);
 }
 
-bool GraphicsLayer::addAnimation(WebAnimation* animation)
+bool GraphicsLayer::addAnimation(PassOwnPtr<WebAnimation> popAnimation)
 {
+    OwnPtr<WebAnimation> animation(popAnimation);
     ASSERT(animation);
     platformLayer()->setAnimationDelegate(this);
 
     // Remove any existing animations with the same animation id and target property.
     platformLayer()->removeAnimation(animation->id(), animation->targetProperty());
-    return platformLayer()->addAnimation(animation);
+    return platformLayer()->addAnimation(animation.get());

[jamesr, 2013/09/20 18:52:14]

you need to leakPtr() here, right? otherwise ~OwnPtr<> for the 'animation' local
will also delete this causing a double-delete

[dshwang, 2013/09/20 19:03:58]

WebLayerImpl does not delete a WebAnimation instance. WebLayerImpl gains the
ownership of the cc::Animation instance which is the member variable of
WebAnimation instance. So GraphicsLayer deletes the WebAnimation instance like
as-is.

animation.leakPtr() causes memory leak for a while because chomium does not
delete now.  animation.leakPtr() is next step. I'm investigating how to handle
it elegantly.

 }
 
 void GraphicsLayer::pauseAnimation(int animationId, double timeOffset)
 {
     platformLayer()->pauseAnimation(animationId, timeOffset);
 }
 
 void GraphicsLayer::removeAnimation(int animationId)
 {
     platformLayer()->removeAnimation(animationId);
@@ skipping 192 matching lines @@
 #ifndef NDEBUG
 void showGraphicsLayerTree(const WebCore::GraphicsLayer* layer)
 {
     if (!layer)
         return;
 
     String output = layer->layerTreeAsText(WebCore::LayerTreeIncludesDebugInfo);
     fprintf(stderr, "%s\n", output.utf8().data());
 }
 #endif