Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/gpu/gl/GLTestContext.cpp

Issue 2383383002: Move GPU fences into sk_gpu_test (Closed)
Patch Set: Move GPU fences into sk_gpu_test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gpu/gl/GLTestContext.cpp
diff --git a/tools/gpu/gl/GLTestContext.cpp b/tools/gpu/gl/GLTestContext.cpp
index 68980922cdc4c986ef1c3fae325a2ec6dfd9a8bf..60e10ec3c8231f6dcb4624f56b34f4765d4d94f8 100644
--- a/tools/gpu/gl/GLTestContext.cpp
+++ b/tools/gpu/gl/GLTestContext.cpp
@@ -9,20 +9,25 @@
#include "gl/GrGLUtil.h"
namespace sk_gpu_test {
-class GLTestContext::GLFenceSync : public SkGpuFenceSync {
+
+namespace {
+
+class GLFenceSync : public FenceSync {
public:
static GLFenceSync* CreateIfSupported(const GLTestContext*);
- SkPlatformGpuFence SK_WARN_UNUSED_RESULT insertFence() const override;
- bool waitFence(SkPlatformGpuFence fence) const override;
- void deleteFence(SkPlatformGpuFence fence) const override;
+ PlatformFence SK_WARN_UNUSED_RESULT insertFence() const override;
+ bool waitFence(PlatformFence fence) const override;
+ void deleteFence(PlatformFence fence) const override;
private:
- GLFenceSync() {}
+ GLFenceSync(const GLTestContext*, const char* ext = "");
- static const GrGLenum GL_SYNC_GPU_COMMANDS_COMPLETE = 0x9117;
- static const GrGLenum GL_WAIT_FAILED = 0x911d;
- static const GrGLbitfield GL_SYNC_FLUSH_COMMANDS_BIT = 0x00000001;
+ bool validate() { return fGLFenceSync && fGLClientWaitSync && fGLDeleteSync; }
+
+ static constexpr GrGLenum GL_SYNC_GPU_COMMANDS_COMPLETE = 0x9117;
+ static constexpr GrGLenum GL_WAIT_FAILED = 0x911d;
+ static constexpr GrGLbitfield GL_SYNC_FLUSH_COMMANDS_BIT = 0x00000001;
typedef struct __GLsync *GLsync;
@@ -34,16 +39,56 @@ private:
GLClientWaitSyncProc fGLClientWaitSync;
GLDeleteSyncProc fGLDeleteSync;
- typedef SkGpuFenceSync INHERITED;
+ typedef FenceSync INHERITED;
};
+GLFenceSync* GLFenceSync::CreateIfSupported(const GLTestContext* ctx) {
+ SkAutoTDelete<GLFenceSync> ret;
+ if (kGL_GrGLStandard == ctx->gl()->fStandard) {
+ const GrGLubyte* versionStr;
+ GR_GL_CALL_RET(ctx->gl(), versionStr, GetString(GR_GL_VERSION));
+ if (GrGLGetVersion(ctx->gl()) < GR_GL_VER(3,2) && !ctx->gl()->hasExtension("GL_ARB_sync")) {
+ return nullptr;
+ }
+ ret.reset(new GLFenceSync(ctx));
+ } else {
+ if (!ctx->gl()->hasExtension("GL_APPLE_sync")) {
+ return nullptr;
+ }
+ ret.reset(new GLFenceSync(ctx, "APPLE"));
+ }
+ return ret->validate() ? ret.release() : nullptr;
+}
+
+GLFenceSync::GLFenceSync(const GLTestContext* ctx, const char* ext) {
+ ctx->getGLProcAddress(&fGLFenceSync, "glFenceSync");
+ ctx->getGLProcAddress(&fGLClientWaitSync, "glClientWaitSync");
+ ctx->getGLProcAddress(&fGLDeleteSync, "glDeleteSync");
+}
+
+PlatformFence GLFenceSync::insertFence() const {
+ return reinterpret_cast<PlatformFence>(fGLFenceSync(GL_SYNC_GPU_COMMANDS_COMPLETE, 0));
+}
+
+bool GLFenceSync::waitFence(PlatformFence fence) const {
+ GLsync glsync = reinterpret_cast<GLsync>(fence);
+ return GL_WAIT_FAILED != fGLClientWaitSync(glsync, GL_SYNC_FLUSH_COMMANDS_BIT, -1);
+}
+
+void GLFenceSync::deleteFence(PlatformFence fence) const {
+ GLsync glsync = reinterpret_cast<GLsync>(fence);
+ fGLDeleteSync(glsync);
+}
+
+} // anonymous namespace
+
GLTestContext::GLTestContext() : TestContext() {}
GLTestContext::~GLTestContext() {
SkASSERT(nullptr == fGL.get());
}
-void GLTestContext::init(const GrGLInterface* gl, SkGpuFenceSync* fenceSync) {
+void GLTestContext::init(const GrGLInterface* gl, FenceSync* fenceSync) {
SkASSERT(!fGL.get());
fGL.reset(gl);
fFenceSync = fenceSync ? fenceSync : GLFenceSync::CreateIfSupported(this);
@@ -73,55 +118,6 @@ void GLTestContext::finish() {
}
}
-GLTestContext::GLFenceSync* GLTestContext::GLFenceSync::CreateIfSupported(const GLTestContext* ctx) {
- SkAutoTDelete<GLFenceSync> ret(new GLFenceSync);
-
- if (kGL_GrGLStandard == ctx->gl()->fStandard) {
- const GrGLubyte* versionStr;
- GR_GL_CALL_RET(ctx->gl(), versionStr, GetString(GR_GL_VERSION));
- GrGLVersion version = GrGLGetVersionFromString(reinterpret_cast<const char*>(versionStr));
- if (version < GR_GL_VER(3,2) && !ctx->gl()->hasExtension("GL_ARB_sync")) {
- return nullptr;
- }
- ret->fGLFenceSync = reinterpret_cast<GLFenceSyncProc>(
- ctx->onPlatformGetProcAddress("glFenceSync"));
- ret->fGLClientWaitSync = reinterpret_cast<GLClientWaitSyncProc>(
- ctx->onPlatformGetProcAddress("glClientWaitSync"));
- ret->fGLDeleteSync = reinterpret_cast<GLDeleteSyncProc>(
- ctx->onPlatformGetProcAddress("glDeleteSync"));
- } else {
- if (!ctx->gl()->hasExtension("GL_APPLE_sync")) {
- return nullptr;
- }
- ret->fGLFenceSync = reinterpret_cast<GLFenceSyncProc>(
- ctx->onPlatformGetProcAddress("glFenceSyncAPPLE"));
- ret->fGLClientWaitSync = reinterpret_cast<GLClientWaitSyncProc>(
- ctx->onPlatformGetProcAddress("glClientWaitSyncAPPLE"));
- ret->fGLDeleteSync = reinterpret_cast<GLDeleteSyncProc>(
- ctx->onPlatformGetProcAddress("glDeleteSyncAPPLE"));
- }
-
- if (!ret->fGLFenceSync || !ret->fGLClientWaitSync || !ret->fGLDeleteSync) {
- return nullptr;
- }
-
- return ret.release();
-}
-
-SkPlatformGpuFence GLTestContext::GLFenceSync::insertFence() const {
- return fGLFenceSync(GL_SYNC_GPU_COMMANDS_COMPLETE, 0);
-}
-
-bool GLTestContext::GLFenceSync::waitFence(SkPlatformGpuFence fence) const {
- GLsync glsync = static_cast<GLsync>(fence);
- return GL_WAIT_FAILED != fGLClientWaitSync(glsync, GL_SYNC_FLUSH_COMMANDS_BIT, -1);
-}
-
-void GLTestContext::GLFenceSync::deleteFence(SkPlatformGpuFence fence) const {
- GLsync glsync = static_cast<GLsync>(fence);
- fGLDeleteSync(glsync);
-}
-
GrGLint GLTestContext::createTextureRectangle(int width, int height, GrGLenum internalFormat,
GrGLenum externalFormat, GrGLenum externalType,
GrGLvoid* data) {

Powered by Google App Engine
This is Rietveld 408576698