content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc - Issue 2383373002: Reduce SurfaceIdAllocator usage and tie SurfaceFactory to a single FrameSinkId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

Issue 2383373002: Reduce SurfaceIdAllocator usage and tie SurfaceFactory to a single FrameSinkId (Closed)

Patch Set: Fix TestRenderViewHost + Mac Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/delegated_frame_host.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | services/ui/surfaces/display_compositor.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

diff --git a/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc b/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

index d7d04a7d62b0b6086fb7b2ba2f8a3e8f60caa9b8..0cb7f5c532a93811fe6ff075708aed83896a367d 100644

--- a/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

+++ b/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

@@ -45,7 +45,8 @@ void OffscreenCanvasCompositorFrameSink::SubmitCompositorFrame(

const SubmitCompositorFrameCallback& callback) {

if (!surface_factory_) {

cc::SurfaceManager* manager = GetSurfaceManager();

- surface_factory_ = base::MakeUnique<cc::SurfaceFactory>(manager, this);

+ surface_factory_ = base::MakeUnique<cc::SurfaceFactory>(

+ surface_id_.frame_sink_id(), manager, this);

surface_factory_->Create(surface_id_);

manager->RegisterFrameSinkId(surface_id_.frame_sink_id());