Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: cc/surfaces/display_unittest.cc

Issue 2383373002: Reduce SurfaceIdAllocator usage and tie SurfaceFactory to a single FrameSinkId (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/direct_compositor_frame_sink_unittest.cc ('k') | cc/surfaces/surface_aggregator_perftest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/display_unittest.cc
diff --git a/cc/surfaces/display_unittest.cc b/cc/surfaces/display_unittest.cc
index cbedd2f9b44c6a3c31ce9d5840514b54a727adbd..e4a29d78f03b94ccebe417fe91ab935d77a2e86f 100644
--- a/cc/surfaces/display_unittest.cc
+++ b/cc/surfaces/display_unittest.cc
@@ -99,14 +99,14 @@ class TestDisplayScheduler : public DisplayScheduler {
class DisplayTest : public testing::Test {
public:
DisplayTest()
- : factory_(&manager_, &surface_factory_client_),
+ : factory_(kArbitraryFrameSinkId, &manager_, &surface_factory_client_),
id_allocator_(kArbitraryFrameSinkId),
task_runner_(new base::NullTaskRunner) {
- manager_.RegisterFrameSinkId(id_allocator_.frame_sink_id());
+ manager_.RegisterFrameSinkId(kArbitraryFrameSinkId);
}
~DisplayTest() override {
- manager_.InvalidateFrameSinkId(id_allocator_.frame_sink_id());
+ manager_.InvalidateFrameSinkId(kArbitraryFrameSinkId);
}
void SetUpDisplay(const RendererSettings& settings,
@@ -182,7 +182,7 @@ TEST_F(DisplayTest, DisplayDamaged) {
SetUpDisplay(settings, nullptr);
StubDisplayClient client;
- display_->Initialize(&client, &manager_, id_allocator_.frame_sink_id());
+ display_->Initialize(&client, &manager_, kArbitraryFrameSinkId);
SurfaceId surface_id(id_allocator_.GenerateId());
EXPECT_FALSE(scheduler_->damaged);
@@ -445,7 +445,7 @@ TEST_F(DisplayTest, Finish) {
SetUpDisplay(settings, std::move(context));
StubDisplayClient client;
- display_->Initialize(&client, &manager_, id_allocator_.frame_sink_id());
+ display_->Initialize(&client, &manager_, kArbitraryFrameSinkId);
display_->SetSurfaceId(surface_id, 1.f);
« no previous file with comments | « cc/surfaces/direct_compositor_frame_sink_unittest.cc ('k') | cc/surfaces/surface_aggregator_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698