Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2537)

Unified Diff: cc/surfaces/direct_compositor_frame_sink.h

Issue 2383373002: Reduce SurfaceIdAllocator usage and tie SurfaceFactory to a single FrameSinkId (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/compositor_frame_sink.h ('k') | cc/surfaces/direct_compositor_frame_sink.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/direct_compositor_frame_sink.h
diff --git a/cc/surfaces/direct_compositor_frame_sink.h b/cc/surfaces/direct_compositor_frame_sink.h
index 701f97509d06ee3a27c53773329fc3c540852a6c..b9213d0fd732c87c0f1247b2f8f176b5c05f681c 100644
--- a/cc/surfaces/direct_compositor_frame_sink.h
+++ b/cc/surfaces/direct_compositor_frame_sink.h
@@ -11,6 +11,7 @@
#include "cc/surfaces/display_client.h"
#include "cc/surfaces/surface_factory.h"
#include "cc/surfaces/surface_factory_client.h"
+#include "cc/surfaces/surface_id_allocator.h"
#include "cc/surfaces/surfaces_export.h"
namespace cc {
@@ -28,14 +29,14 @@ class CC_SURFACES_EXPORT DirectCompositorFrameSink
// The underlying Display, SurfaceManager, and SurfaceIdAllocator must outlive
// this class.
DirectCompositorFrameSink(
+ const FrameSinkId& frame_sink_id,
SurfaceManager* surface_manager,
- SurfaceIdAllocator* allocator,
Display* display,
scoped_refptr<ContextProvider> context_provider,
scoped_refptr<ContextProvider> worker_context_provider);
DirectCompositorFrameSink(
+ const FrameSinkId& frame_sink_id,
SurfaceManager* surface_manager,
- SurfaceIdAllocator* allocator,
Display* display,
scoped_refptr<VulkanContextProvider> vulkan_context_provider);
~DirectCompositorFrameSink() override;
@@ -62,8 +63,9 @@ class CC_SURFACES_EXPORT DirectCompositorFrameSink
// This class is only meant to be used on a single thread.
base::ThreadChecker thread_checker_;
+ FrameSinkId frame_sink_id_;
SurfaceManager* surface_manager_;
- SurfaceIdAllocator* surface_id_allocator_;
+ SurfaceIdAllocator surface_id_allocator_;
Display* display_;
SurfaceFactory factory_;
SurfaceId delegated_surface_id_;
« no previous file with comments | « cc/output/compositor_frame_sink.h ('k') | cc/surfaces/direct_compositor_frame_sink.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698