Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: services/ui/surfaces/display_compositor.h

Issue 2383373002: Reduce SurfaceIdAllocator usage and tie SurfaceFactory to a single FrameSinkId (Closed)
Patch Set: Fix TestRenderViewHost + Mac Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SERVICES_UI_SURFACES_DISPLAY_COMPOSITOR_H_ 5 #ifndef SERVICES_UI_SURFACES_DISPLAY_COMPOSITOR_H_
6 #define SERVICES_UI_SURFACES_DISPLAY_COMPOSITOR_H_ 6 #define SERVICES_UI_SURFACES_DISPLAY_COMPOSITOR_H_
7 7
8 #include "cc/surfaces/display_client.h" 8 #include "cc/surfaces/display_client.h"
9 #include "cc/surfaces/surface.h" 9 #include "cc/surfaces/surface.h"
10 #include "cc/surfaces/surface_factory.h" 10 #include "cc/surfaces/surface_factory.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 // SurfaceFactoryClient implementation. 61 // SurfaceFactoryClient implementation.
62 void ReturnResources(const cc::ReturnedResourceArray& resources) override; 62 void ReturnResources(const cc::ReturnedResourceArray& resources) override;
63 void SetBeginFrameSource(cc::BeginFrameSource* begin_frame_source) override; 63 void SetBeginFrameSource(cc::BeginFrameSource* begin_frame_source) override;
64 64
65 // DisplayClient implementation. 65 // DisplayClient implementation.
66 void DisplayOutputSurfaceLost() override; 66 void DisplayOutputSurfaceLost() override;
67 void DisplayWillDrawAndSwap(bool will_draw_and_swap, 67 void DisplayWillDrawAndSwap(bool will_draw_and_swap,
68 const cc::RenderPassList& render_passes) override; 68 const cc::RenderPassList& render_passes) override;
69 void DisplayDidDrawAndSwap() override; 69 void DisplayDidDrawAndSwap() override;
70 70
71 cc::FrameSinkId frame_sink_id_;
sky 2016/10/03 19:18:25 If possible make this const.
Fady Samuel 2016/10/03 19:45:29 Done.
71 scoped_refptr<base::SingleThreadTaskRunner> task_runner_; 72 scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
72 scoped_refptr<SurfacesState> surfaces_state_; 73 scoped_refptr<SurfacesState> surfaces_state_;
74 cc::SurfaceIdAllocator allocator_;
73 cc::SurfaceFactory factory_; 75 cc::SurfaceFactory factory_;
74 cc::SurfaceIdAllocator allocator_;
75 cc::SurfaceId surface_id_; 76 cc::SurfaceId surface_id_;
76 77
77 gfx::Size display_size_; 78 gfx::Size display_size_;
78 std::unique_ptr<cc::Display> display_; 79 std::unique_ptr<cc::Display> display_;
79 DISALLOW_COPY_AND_ASSIGN(DisplayCompositor); 80 DISALLOW_COPY_AND_ASSIGN(DisplayCompositor);
80 }; 81 };
81 82
82 } // namespace ui 83 } // namespace ui
83 84
84 #endif // SERVICES_UI_SURFACES_DISPLAY_COMPOSITOR_H_ 85 #endif // SERVICES_UI_SURFACES_DISPLAY_COMPOSITOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698