Reduce SurfaceIdAllocator usage and tie SurfaceFactory to a single FrameSinkId

services/ui/surfaces/display_compositor.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/ui/surfaces/display_compositor.h"
 
 #include "cc/output/copy_output_request.h"
 #include "cc/output/output_surface.h"
 #include "cc/output/renderer_settings.h"
 #include "cc/output/texture_mailbox_deleter.h"
@@ skipping 11 matching lines @@
 #include "services/ui/surfaces/direct_output_surface_ozone.h"
 #endif
 
 namespace ui {
 
 DisplayCompositor::DisplayCompositor(
     scoped_refptr<base::SingleThreadTaskRunner> task_runner,
     gfx::AcceleratedWidget widget,
     scoped_refptr<gpu::GpuChannelHost> gpu_channel,
     const scoped_refptr<SurfacesState>& surfaces_state)
-    : task_runner_(task_runner),
+    : frame_sink_id_(surfaces_state->next_client_id(), 0),
+      task_runner_(task_runner),
       surfaces_state_(surfaces_state),
-      factory_(surfaces_state->manager(), this),
-      allocator_(cc::FrameSinkId(surfaces_state->next_client_id(), 0)) {
-  surfaces_state_->manager()->RegisterFrameSinkId(allocator_.frame_sink_id());
-  surfaces_state_->manager()->RegisterSurfaceFactoryClient(
-      allocator_.frame_sink_id(), this);
+      allocator_(frame_sink_id_),
+      factory_(frame_sink_id_, surfaces_state->manager(), this) {
+  surfaces_state_->manager()->RegisterFrameSinkId(frame_sink_id_);
+  surfaces_state_->manager()->RegisterSurfaceFactoryClient(frame_sink_id_,
+                                                           this);
 
   gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager =
       gpu_channel->gpu_memory_buffer_manager();
   scoped_refptr<SurfacesContextProvider> surfaces_context_provider(
       new SurfacesContextProvider(widget, std::move(gpu_channel)));
   // TODO(rjkroege): If there is something better to do than CHECK, add it.
   CHECK(surfaces_context_provider->BindToCurrentThread());
 
   std::unique_ptr<cc::SyntheticBeginFrameSource> synthetic_begin_frame_source(
       new cc::DelayBasedBeginFrameSource(
@@ skipping 19 matching lines @@
 
   std::unique_ptr<cc::DisplayScheduler> scheduler(
       new cc::DisplayScheduler(synthetic_begin_frame_source.get(),
                                task_runner_.get(), max_frames_pending));
 
   display_.reset(new cc::Display(
       nullptr /* bitmap_manager */, gpu_memory_buffer_manager,
       cc::RendererSettings(), std::move(synthetic_begin_frame_source),
       std::move(display_output_surface), std::move(scheduler),
       base::MakeUnique<cc::TextureMailboxDeleter>(task_runner_.get())));
-  display_->Initialize(this, surfaces_state_->manager(),
-                       allocator_.frame_sink_id());
+  display_->Initialize(this, surfaces_state_->manager(), frame_sink_id_);
   display_->SetVisible(true);
 }
 
 DisplayCompositor::~DisplayCompositor() {
-  surfaces_state_->manager()->UnregisterSurfaceFactoryClient(
-      allocator_.frame_sink_id());
-  surfaces_state_->manager()->InvalidateFrameSinkId(allocator_.frame_sink_id());
+  surfaces_state_->manager()->UnregisterSurfaceFactoryClient(frame_sink_id_);
+  surfaces_state_->manager()->InvalidateFrameSinkId(frame_sink_id_);
 }
 
 void DisplayCompositor::SubmitCompositorFrame(
     cc::CompositorFrame frame,
     const base::Callback<void()>& callback) {
   gfx::Size frame_size =
       frame.delegated_frame_data->render_pass_list.back()->output_rect.size();
   if (frame_size.IsEmpty() || frame_size != display_size_) {
     if (!surface_id_.is_null())
       factory_.Destroy(surface_id_);
@@ skipping 33 matching lines @@
   // This notification is not relevant to our client outside of tests.
 }
 
 void DisplayCompositor::DisplayDidDrawAndSwap() {
   // This notification is not relevant to our client outside of tests. We
   // unblock the client from the DrawCallback when the surface is going to
   // be drawn.
 }
 
 }  // namespace ui