Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2383373002: Reduce SurfaceIdAllocator usage and tie SurfaceFactory to a single FrameSinkId (Closed)
Patch Set: Fix TestRenderViewHost + Mac Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <utility> 10 #include <utility>
(...skipping 1444 matching lines...) Expand 10 before | Expand all | Expand 10 after
1455 // postMessage to the inner WebContents. 1455 // postMessage to the inner WebContents.
1456 render_manager->CreateOuterDelegateProxy( 1456 render_manager->CreateOuterDelegateProxy(
1457 outer_contents_frame->GetSiteInstance(), 1457 outer_contents_frame->GetSiteInstance(),
1458 static_cast<RenderFrameHostImpl*>(outer_contents_frame)); 1458 static_cast<RenderFrameHostImpl*>(outer_contents_frame));
1459 1459
1460 render_manager->SetRWHViewForInnerContents( 1460 render_manager->SetRWHViewForInnerContents(
1461 render_manager->GetRenderWidgetHostView()); 1461 render_manager->GetRenderWidgetHostView());
1462 1462
1463 static_cast<RenderWidgetHostViewChildFrame*>( 1463 static_cast<RenderWidgetHostViewChildFrame*>(
1464 render_manager->GetRenderWidgetHostView()) 1464 render_manager->GetRenderWidgetHostView())
1465 ->RegisterSurfaceNamespaceId(); 1465 ->RegisterFrameSinkId();
1466 1466
1467 // At this point, we should destroy the TextInputManager which will notify all 1467 // At this point, we should destroy the TextInputManager which will notify all
1468 // the RWHV in this WebContents. The RWHV in this WebContents should use the 1468 // the RWHV in this WebContents. The RWHV in this WebContents should use the
1469 // TextInputManager owned by the outer WebContents. 1469 // TextInputManager owned by the outer WebContents.
1470 // TODO(ekaramad): Is it possible to have TextInputState before attaching to 1470 // TODO(ekaramad): Is it possible to have TextInputState before attaching to
1471 // outer WebContents? In such a case, is this still the right way to hand off 1471 // outer WebContents? In such a case, is this still the right way to hand off
1472 // state tracking from inner WebContents's TextInputManager to that of the 1472 // state tracking from inner WebContents's TextInputManager to that of the
1473 // outer WebContent (crbug.com/609846)? 1473 // outer WebContent (crbug.com/609846)?
1474 text_input_manager_.reset(nullptr); 1474 text_input_manager_.reset(nullptr);
1475 } 1475 }
(...skipping 3789 matching lines...) Expand 10 before | Expand all | Expand 10 after
5265 dialog_manager_ = dialog_manager; 5265 dialog_manager_ = dialog_manager;
5266 } 5266 }
5267 5267
5268 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) { 5268 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) {
5269 auto it = binding_sets_.find(interface_name); 5269 auto it = binding_sets_.find(interface_name);
5270 if (it != binding_sets_.end()) 5270 if (it != binding_sets_.end())
5271 binding_sets_.erase(it); 5271 binding_sets_.erase(it);
5272 } 5272 }
5273 5273
5274 } // namespace content 5274 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698