Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2383373002: Reduce SurfaceIdAllocator usage and tie SurfaceFactory to a single FrameSinkId (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <utility> 10 #include <utility>
(...skipping 1446 matching lines...) Expand 10 before | Expand all | Expand 10 after
1457 // postMessage to the inner WebContents. 1457 // postMessage to the inner WebContents.
1458 render_manager->CreateOuterDelegateProxy( 1458 render_manager->CreateOuterDelegateProxy(
1459 outer_contents_frame->GetSiteInstance(), 1459 outer_contents_frame->GetSiteInstance(),
1460 static_cast<RenderFrameHostImpl*>(outer_contents_frame)); 1460 static_cast<RenderFrameHostImpl*>(outer_contents_frame));
1461 1461
1462 render_manager->SetRWHViewForInnerContents( 1462 render_manager->SetRWHViewForInnerContents(
1463 render_manager->GetRenderWidgetHostView()); 1463 render_manager->GetRenderWidgetHostView());
1464 1464
1465 static_cast<RenderWidgetHostViewChildFrame*>( 1465 static_cast<RenderWidgetHostViewChildFrame*>(
1466 render_manager->GetRenderWidgetHostView()) 1466 render_manager->GetRenderWidgetHostView())
1467 ->RegisterSurfaceNamespaceId(); 1467 ->RegisterFrameSinkId();
1468 1468
1469 // At this point, we should destroy the TextInputManager which will notify all 1469 // At this point, we should destroy the TextInputManager which will notify all
1470 // the RWHV in this WebContents. The RWHV in this WebContents should use the 1470 // the RWHV in this WebContents. The RWHV in this WebContents should use the
1471 // TextInputManager owned by the outer WebContents. 1471 // TextInputManager owned by the outer WebContents.
1472 // TODO(ekaramad): Is it possible to have TextInputState before attaching to 1472 // TODO(ekaramad): Is it possible to have TextInputState before attaching to
1473 // outer WebContents? In such a case, is this still the right way to hand off 1473 // outer WebContents? In such a case, is this still the right way to hand off
1474 // state tracking from inner WebContents's TextInputManager to that of the 1474 // state tracking from inner WebContents's TextInputManager to that of the
1475 // outer WebContent (crbug.com/609846)? 1475 // outer WebContent (crbug.com/609846)?
1476 text_input_manager_.reset(nullptr); 1476 text_input_manager_.reset(nullptr);
1477 } 1477 }
(...skipping 3789 matching lines...) Expand 10 before | Expand all | Expand 10 after
5267 dialog_manager_ = dialog_manager; 5267 dialog_manager_ = dialog_manager;
5268 } 5268 }
5269 5269
5270 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) { 5270 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) {
5271 auto it = binding_sets_.find(interface_name); 5271 auto it = binding_sets_.find(interface_name);
5272 if (it != binding_sets_.end()) 5272 if (it != binding_sets_.end())
5273 binding_sets_.erase(it); 5273 binding_sets_.erase(it);
5274 } 5274 }
5275 5275
5276 } // namespace content 5276 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698