Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: android_webview/browser/hardware_renderer.h

Issue 2383373002: Reduce SurfaceIdAllocator usage and tie SurfaceFactory to a single FrameSinkId (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | android_webview/browser/hardware_renderer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_BROWSER_HARDWARE_RENDERER_H_ 5 #ifndef ANDROID_WEBVIEW_BROWSER_HARDWARE_RENDERER_H_
6 #define ANDROID_WEBVIEW_BROWSER_HARDWARE_RENDERER_H_ 6 #define ANDROID_WEBVIEW_BROWSER_HARDWARE_RENDERER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "android_webview/browser/compositor_id.h" 10 #include "android_webview/browser/compositor_id.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
13 #include "cc/surfaces/frame_sink_id.h"
13 #include "cc/surfaces/surface_factory_client.h" 14 #include "cc/surfaces/surface_factory_client.h"
14 #include "cc/surfaces/surface_id.h" 15 #include "cc/surfaces/surface_id.h"
15 16
16 struct AwDrawGLInfo; 17 struct AwDrawGLInfo;
17 18
18 namespace cc { 19 namespace cc {
19 class Display; 20 class Display;
20 class SurfaceFactory; 21 class SurfaceFactory;
21 class SurfaceIdAllocator; 22 class SurfaceIdAllocator;
22 class SurfaceManager; 23 class SurfaceManager;
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 60
60 // Infromation from UI on last commit. 61 // Infromation from UI on last commit.
61 gfx::Vector2d scroll_offset_; 62 gfx::Vector2d scroll_offset_;
62 63
63 // This holds the last ChildFrame received. Contains the frame info of the 64 // This holds the last ChildFrame received. Contains the frame info of the
64 // last frame. The |frame| member may be null if it's already submitted to 65 // last frame. The |frame| member may be null if it's already submitted to
65 // SurfaceFactory. 66 // SurfaceFactory.
66 std::unique_ptr<ChildFrame> child_frame_; 67 std::unique_ptr<ChildFrame> child_frame_;
67 68
68 const scoped_refptr<SurfacesInstance> surfaces_; 69 const scoped_refptr<SurfacesInstance> surfaces_;
70 cc::FrameSinkId frame_sink_id_;
69 const std::unique_ptr<cc::SurfaceIdAllocator> surface_id_allocator_; 71 const std::unique_ptr<cc::SurfaceIdAllocator> surface_id_allocator_;
70 std::unique_ptr<cc::SurfaceFactory> surface_factory_; 72 std::unique_ptr<cc::SurfaceFactory> surface_factory_;
71 cc::SurfaceId child_id_; 73 cc::SurfaceId child_id_;
72 CompositorID compositor_id_; 74 CompositorID compositor_id_;
73 // HardwareRenderer guarantees resources are returned in the order of 75 // HardwareRenderer guarantees resources are returned in the order of
74 // compositor_frame_sink_id, and resources for old output surfaces are 76 // compositor_frame_sink_id, and resources for old output surfaces are
75 // dropped. 77 // dropped.
76 uint32_t last_committed_compositor_frame_sink_id_; 78 uint32_t last_committed_compositor_frame_sink_id_;
77 uint32_t last_submitted_compositor_frame_sink_id_; 79 uint32_t last_submitted_compositor_frame_sink_id_;
78 80
79 DISALLOW_COPY_AND_ASSIGN(HardwareRenderer); 81 DISALLOW_COPY_AND_ASSIGN(HardwareRenderer);
80 }; 82 };
81 83
82 } // namespace android_webview 84 } // namespace android_webview
83 85
84 #endif // ANDROID_WEBVIEW_BROWSER_HARDWARE_RENDERER_H_ 86 #endif // ANDROID_WEBVIEW_BROWSER_HARDWARE_RENDERER_H_
OLDNEW
« no previous file with comments | « no previous file | android_webview/browser/hardware_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698