Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2383313002: Remove ash localization from display_manager.cc (Closed)

Created:
4 years, 2 months ago by rjkroege
Modified:
4 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ash localization from display_manager.cc As part of preparing ash::DisplayManager for relocation to ui, eliminate its dependency on ash localization strings. BUG=581462 Committed: https://crrev.com/a136f790b12e1558a73c8f884049c0ffd9e0b74e Cr-Commit-Position: refs/heads/master@{#423766}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M ash/display/display_manager.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/display/display_manager.cc View 1 3 chunks +2 lines, -4 lines 0 comments Download
M ash/display/window_tree_host_manager.h View 2 chunks +3 lines, -1 line 0 comments Download
M ash/display/window_tree_host_manager.cc View 1 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rjkroege
ptal
4 years, 2 months ago (2016-09-30 22:44:53 UTC) #2
oshima
lgtm https://codereview.chromium.org/2383313002/diff/1/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/2383313002/diff/1/ash/display/display_manager.cc#newcode612 ash/display/display_manager.cc:612: // l10n_util::GetStringUTF8(IDS_ASH_INTERNAL_DISPLAY_NAME), remove this
4 years, 2 months ago (2016-09-30 23:03:40 UTC) #3
rjkroege
https://codereview.chromium.org/2383313002/diff/1/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/2383313002/diff/1/ash/display/display_manager.cc#newcode612 ash/display/display_manager.cc:612: // l10n_util::GetStringUTF8(IDS_ASH_INTERNAL_DISPLAY_NAME), On 2016/09/30 23:03:40, oshima wrote: > remove ...
4 years, 2 months ago (2016-10-05 00:40:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383313002/40001
4 years, 2 months ago (2016-10-07 00:19:52 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-07 00:47:09 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 00:49:32 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a136f790b12e1558a73c8f884049c0ffd9e0b74e
Cr-Commit-Position: refs/heads/master@{#423766}

Powered by Google App Engine
This is Rietveld 408576698