Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 23833005: Revert 221023 "Reland after fix: Improve <webview> autosize:" (Closed)

Created:
7 years, 3 months ago by pneubeck (no reviews)
Modified:
7 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 221023 "Reland after fix: Improve <webview> autosize:" > Reland after fix: Improve <webview> autosize: > a. Expand/shrink <webview> element when 'sizechange' event fires, to > match with the new view size (in shim). > b. For SW mode, fix a bug where damage buffer would remain smaller than > the view size and would result in crash. Added test for this case. > > BUG=173238, 282116 > Test=WebViewTest.AutoSize.*, <webview>.autosize=true now should autosize > webview container within the constraints > (minwidth/maxwidth/minheight/maxheight). > > Review URL: https://chromiumcodereview.appspot.com/23503023 Best guess that this caused flakiness of WebViewTest.Shim_TestAutosizeRemoveAttributes. See here http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=browser_tests&tests=WebViewTest.Shim_TestAutosizeRemoveAttributes TBR=lazyboy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221164

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
pneubeck (no reviews)
7 years, 3 months ago (2013-09-04 10:05:57 UTC) #1
pneubeck (no reviews)
7 years, 3 months ago (2013-09-04 10:07:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r221164.

Powered by Google App Engine
This is Rietveld 408576698