Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: runtime/platform/assert.h

Issue 2383293003: - fix some cases where we are using uninitialized memory (Closed)
Patch Set: Fix lint issue. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/dartutils.cc ('k') | runtime/platform/assert.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/platform/assert.h
diff --git a/runtime/platform/assert.h b/runtime/platform/assert.h
index 0e8969c7eb835219468d4828c825a1f8a87c70b0..9c810c5b3328efd712d4eb9fc3f87a4501d02182 100644
--- a/runtime/platform/assert.h
+++ b/runtime/platform/assert.h
@@ -14,6 +14,7 @@
#endif
#include "platform/globals.h"
+#include "platform/memory_sanitizer.h"
#if !defined(DEBUG) && !defined(NDEBUG)
#error neither DEBUG nor NDEBUG defined
@@ -142,6 +143,7 @@ void DynamicAssertionHelper::FloatEquals(const E& expected,
template<typename E, typename A>
+NO_SANITIZE_MEMORY
void DynamicAssertionHelper::StringEquals(const E& expected, const A& actual) {
std::ostringstream ess, ass;
ess << expected;
@@ -153,6 +155,7 @@ void DynamicAssertionHelper::StringEquals(const E& expected, const A& actual) {
template<typename E, typename A>
+NO_SANITIZE_MEMORY
void DynamicAssertionHelper::IsSubstring(const E& needle, const A& haystack) {
std::ostringstream ess, ass;
ess << needle;
@@ -165,6 +168,7 @@ void DynamicAssertionHelper::IsSubstring(const E& needle, const A& haystack) {
template<typename E, typename A>
+NO_SANITIZE_MEMORY
void DynamicAssertionHelper::IsNotSubstring(const E& needle,
const A& haystack) {
std::ostringstream ess, ass;
« no previous file with comments | « runtime/bin/dartutils.cc ('k') | runtime/platform/assert.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698