- fix some cases where we are using uninitialized memory

runtime/vm/native_entry.cc

Index: runtime/vm/native_entry.cc
diff --git a/runtime/vm/native_entry.cc b/runtime/vm/native_entry.cc
index e1e7e45e7f78115690dba43a1edf37a98905303c..ad6d2209715412f94f9a658e0f51e1dfbc4543f7 100644
--- a/runtime/vm/native_entry.cc
+++ b/runtime/vm/native_entry.cc
@@ -99,6 +99,7 @@ uword NativeEntry::NativeCallWrapperEntry() {
 }
 
 
+NO_SANITIZE_MEMORY

[Florian Schneider, 2016/10/04 21:02:02]

Here, it would be nice to figure out why the unpoison that we have is not
enough. I wonder if there is some problem with msan itself?

[siva, 2016/10/05 20:38:07]

Figured out what the problem was, we need to unpoison the contents
of the return value location also (see ArgAt and ReturnValue functions in class
NativeArguments).

I have removed this NO_SANITIZE_MEMORY from here.

 bool NativeEntry::ReturnValueIsError(NativeArguments* arguments) {
   RawObject* retval = arguments->ReturnValue();
   return (retval->IsHeapObject() &&