runtime/platform/memory_sanitizer.h - Issue 2383293003: - fix some cases where we are using uninitialized memory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/platform/memory_sanitizer.h

Issue 2383293003: - fix some cases where we are using uninitialized memory (Closed)

Patch Set: Fix lint issue. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « runtime/platform/assert.cc ('k') | runtime/vm/heap.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #ifndef PLATFORM_MEMORY_SANITIZER_H_	5 #ifndef PLATFORM_MEMORY_SANITIZER_H_

6 #define PLATFORM_MEMORY_SANITIZER_H_	6 #define PLATFORM_MEMORY_SANITIZER_H_

7	7

8 #include "platform/globals.h"	8 #include "platform/globals.h"

9	9

10 // Allow the use of Msan (MemorySanitizer). This is needed as Msan needs to be	10 // Allow the use of Msan (MemorySanitizer). This is needed as Msan needs to be

11 // told about areas that are initialized by generated code.	11 // told about areas that are initialized by generated code.

12 #if defined(__has_feature)	12 #if defined(__has_feature)

13 #if __has_feature(memory_sanitizer)	13 #if __has_feature(memory_sanitizer)

14 extern "C" void __msan_unpoison(void *, size_t);	14 extern "C" void __msan_unpoison(void *, size_t);

15 #define MSAN_UNPOISON(ptr, len) __msan_unpoison(ptr, len)	15 #define MSAN_UNPOISON(ptr, len) __msan_unpoison(ptr, len)

	16 #define NO_SANITIZE_MEMORY __attribute__((no_sanitize_memory))

16 #else // __has_feature(memory_sanitizer)	17 #else // __has_feature(memory_sanitizer)

17 #define MSAN_UNPOISON(ptr, len) do {} while (false && (ptr) == 0 && (len) == 0)	18 #define MSAN_UNPOISON(ptr, len) do {} while (false && (ptr) == 0 && (len) == 0)

	19 #define NO_SANITIZE_MEMORY

18 #endif // __has_feature(memory_sanitizer)	20 #endif // __has_feature(memory_sanitizer)

19 #else // defined(__has_feature)	21 #else // defined(__has_feature)

20 #define MSAN_UNPOISON(ptr, len) do {} while (false && (ptr) == 0 && (len) == 0)	22 #define MSAN_UNPOISON(ptr, len) do {} while (false && (ptr) == 0 && (len) == 0)

	23 #define NO_SANITIZE_MEMORY

21 #endif // defined(__has_feature)	24 #endif // defined(__has_feature)

22	25

23 #endif // PLATFORM_MEMORY_SANITIZER_H_	26 #endif // PLATFORM_MEMORY_SANITIZER_H_

OLD	NEW