Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: runtime/vm/heap.cc

Issue 2383293003: - fix some cases where we are using uninitialized memory (Closed)
Patch Set: address self code review. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/heap.h" 5 #include "vm/heap.h"
6 6
7 #include "platform/assert.h" 7 #include "platform/assert.h"
8 #include "platform/utils.h" 8 #include "platform/utils.h"
9 #include "vm/flags.h" 9 #include "vm/flags.h"
10 #include "vm/isolate.h" 10 #include "vm/isolate.h"
(...skipping 20 matching lines...) Expand all
31 intptr_t max_old_gen_words, 31 intptr_t max_old_gen_words,
32 intptr_t max_external_words) 32 intptr_t max_external_words)
33 : isolate_(isolate), 33 : isolate_(isolate),
34 new_space_(this, max_new_gen_semi_words, kNewObjectAlignmentOffset), 34 new_space_(this, max_new_gen_semi_words, kNewObjectAlignmentOffset),
35 old_space_(this, max_old_gen_words, max_external_words), 35 old_space_(this, max_old_gen_words, max_external_words),
36 barrier_(new Monitor()), 36 barrier_(new Monitor()),
37 barrier_done_(new Monitor()), 37 barrier_done_(new Monitor()),
38 read_only_(false), 38 read_only_(false),
39 gc_new_space_in_progress_(false), 39 gc_new_space_in_progress_(false),
40 gc_old_space_in_progress_(false) { 40 gc_old_space_in_progress_(false) {
41 UpdateGlobalMaxUsed();
41 for (int sel = 0; 42 for (int sel = 0;
42 sel < kNumWeakSelectors; 43 sel < kNumWeakSelectors;
43 sel++) { 44 sel++) {
44 new_weak_tables_[sel] = new WeakTable(); 45 new_weak_tables_[sel] = new WeakTable();
45 old_weak_tables_[sel] = new WeakTable(); 46 old_weak_tables_[sel] = new WeakTable();
46 } 47 }
47 stats_.num_ = 0; 48 stats_.num_ = 0;
48 } 49 }
49 50
50 51
(...skipping 810 matching lines...) Expand 10 before | Expand all | Expand 10 after
861 Dart::vm_isolate()->heap()->WriteProtect(false); 862 Dart::vm_isolate()->heap()->WriteProtect(false);
862 } 863 }
863 864
864 865
865 WritableVMIsolateScope::~WritableVMIsolateScope() { 866 WritableVMIsolateScope::~WritableVMIsolateScope() {
866 ASSERT(Dart::vm_isolate()->heap()->UsedInWords(Heap::kNew) == 0); 867 ASSERT(Dart::vm_isolate()->heap()->UsedInWords(Heap::kNew) == 0);
867 Dart::vm_isolate()->heap()->WriteProtect(true); 868 Dart::vm_isolate()->heap()->WriteProtect(true);
868 } 869 }
869 870
870 } // namespace dart 871 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698