- fix some cases where we are using uninitialized memory

runtime/platform/assert.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef PLATFORM_ASSERT_H_
 #define PLATFORM_ASSERT_H_
 
 // TODO(5411406): include sstream for now, once we have a Utils::toString()
 // implemented for all the primitive types we can replace the usage of
 // sstream by Utils::toString()
 #if defined(TESTING)
 #include <sstream>
 #include <string>
 #endif
 
 #include "platform/globals.h"
+#include "platform/memory_sanitizer.h"
 
 #if !defined(DEBUG) && !defined(NDEBUG)
 #error neither DEBUG nor NDEBUG defined
 #elif defined(DEBUG) && defined(NDEBUG)
 #error both DEBUG and NDEBUG defined
 #endif
 
 namespace dart {
 
 class DynamicAssertionHelper {
@@ skipping 108 matching lines @@
   tolss << tol;
   std::string es = ess.str(), as = ass.str(), tols = tolss.str();
   Fail("expected: <%s> but was: <%s> (tolerance: <%s>)",
        es.c_str(),
        as.c_str(),
        tols.c_str());
 }
 
 
 template<typename E, typename A>
+NO_SANITIZE_MEMORY
 void DynamicAssertionHelper::StringEquals(const E& expected, const A& actual) {
   std::ostringstream ess, ass;
   ess << expected;
   ass << actual;
   std::string es = ess.str(), as = ass.str();
   if (as == es) return;
   Fail("expected:\n<\"%s\">\nbut was:\n<\"%s\">", es.c_str(), as.c_str());
 }
 
 
 template<typename E, typename A>
+NO_SANITIZE_MEMORY
 void DynamicAssertionHelper::IsSubstring(const E& needle, const A& haystack) {
   std::ostringstream ess, ass;
   ess << needle;
   ass << haystack;
   std::string es = ess.str(), as = ass.str();
   if (as.find(es) != std::string::npos) return;
   Fail("expected <\"%s\"> to be a substring of <\"%s\">",
        es.c_str(), as.c_str());
 }
 
 
 template<typename E, typename A>
+NO_SANITIZE_MEMORY
 void DynamicAssertionHelper::IsNotSubstring(const E& needle,
                                             const A& haystack) {
   std::ostringstream ess, ass;
   ess << needle;
   ass << haystack;
   std::string es = ess.str(), as = ass.str();
   if (as.find(es) == std::string::npos) return;
   Fail("expected <\"%s\"> to not be a substring of <\"%s\">",
        es.c_str(), as.c_str());
 }
@@ skipping 188 matching lines @@
 
 #define FAIL1(format, p1)                                                      \
   dart::Expect(__FILE__, __LINE__).Fail(format, (p1))
 
 #define FAIL2(format, p1, p2)                                                  \
   dart::Expect(__FILE__, __LINE__).Fail(format, (p1), (p2))
 
 #endif  // defined(TESTING)
 
 #endif  // PLATFORM_ASSERT_H_