remoting/android/java/res/menu/navigation_menu_item.xml - Issue 2383283002: [Remoting Android] Navigation Menu Cleanups

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/android/java/res/menu/navigation_menu_item.xml

Issue 2383283002: [Remoting Android] Navigation Menu Cleanups (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « remoting/android/java/res/menu/help_list_item.xml ('k') | remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java » ('j') | remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>
	Yuwei 2016/09/30 20:47:10 There is also a "navigation_list_item.xml" in java There is also a "navigation_list_item.xml" in java/res/layout and looks like it is not being used and is suppressed for lint. Maybe we can reuse that file name? Lambros 2016/10/03 21:10:03 SGTM. Can do that here or in a separate CL. Show quoted text On 2016/09/30 20:47:10, Yuwei wrote: > There is also a "navigation_list_item.xml" in java/res/layout and looks like it > is not being used and is suppressed for lint. Maybe we can reuse that file name? SGTM. Can do that here or in a separate CL. Yuwei 2016/10/03 22:06:21 Done here. Show quoted text On 2016/10/03 21:10:03, Lambros wrote: > On 2016/09/30 20:47:10, Yuwei wrote: > > There is also a "navigation_list_item.xml" in java/res/layout and looks like > it > > is not being used and is suppressed for lint. Maybe we can reuse that file > name? > > SGTM. Can do that here or in a separate CL. Done here.
2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6	6

7 <TextView xmlns:android="http://schemas.android.com/apk/res/android"	7 <TextView xmlns:android="http://schemas.android.com/apk/res/android"

8 android:drawablePadding="32dp"	8 android:drawablePadding="32dp"

9 android:drawableStart="@drawable/ic_info"

10 android:gravity="center_vertical"	9 android:gravity="center_vertical"

11 android:layout_height="wrap_content"	10 android:layout_height="wrap_content"

12 android:layout_width="match_parent"	11 android:layout_width="match_parent"

13 android:paddingStart="16dp"	12 android:paddingStart="16dp"

14 android:paddingEnd="16dp"	13 android:paddingEnd="16dp"

15 android:paddingTop="16dp"	14 android:paddingTop="16dp"

16 android:paddingBottom="20dp"	15 android:paddingBottom="20dp"

17 android:text="@string/credits"

18 style="@style/NavigationTextStyle"/>	16 style="@style/NavigationTextStyle"/>

OLD	NEW