Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 2383273002: Revert "Add native_testing library to mock @Native classes" (Closed)

Created:
4 years, 2 months ago by sra1
Modified:
4 years, 2 months ago
Reviewers:
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add native_testing library to mock @Native classes" Investigating failures. BUG= Committed: https://github.com/dart-lang/sdk/commit/74deaad759bfbacbdf55bd47e4f175a4c15ac571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -894 lines) Patch
M sdk/lib/_internal/js_runtime/lib/interceptors.dart View 3 chunks +1 line, -17 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/native_helper.dart View 3 chunks +9 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/abstract_class_test.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/bound_closure_super_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/bound_closure_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/browser_compat_1_prepatched_test.dart View 4 chunks +10 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_native/browser_compat_1_unpatched_test.dart View 4 chunks +10 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_native/browser_compat_2_test.dart View 5 chunks +21 lines, -23 lines 0 comments Download
M tests/compiler/dart2js_native/catch_javascript_null_stack_trace_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/core_type_check_native_test.dart View 4 chunks +5 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/dispatch_property_initialization_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/downcast_test.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/error_safeToString_test.dart View 3 chunks +3 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/event_loop_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/fake_thing_2_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/field_type2_test.dart View 2 chunks +1 line, -4 lines 0 comments Download
M tests/compiler/dart2js_native/field_type_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/fixup_get_tag_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/foreign_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/hash_code_test.dart View 1 chunk +2 lines, -14 lines 0 comments Download
M tests/compiler/dart2js_native/inference_of_helper_methods_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/is_check_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/issue9182_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/js_constant_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/jsobject_test.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/load_elim_refinement_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/mirror_intercepted_field_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_call_arity1_frog_test.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_call_arity2_frog_test.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_call_arity3_frog_test.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_checked_arguments1_frog_test.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_checked_fields_frog_test.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_avoids_hidden_name_frog_test.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_2_test.dart View 4 chunks +5 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_3_test.dart View 3 chunks +21 lines, -36 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_test.dart View 3 chunks +3 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance1_frog_test.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance2_frog_test.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance3_frog_test.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance4_frog_test.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_is_check1_frog_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_is_check3_frog_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_with_dart_methods_frog_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_closure_identity_frog_test.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_constructor_name_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_equals_frog_test.dart View 2 chunks +2 lines, -26 lines 0 comments Download
M tests/compiler/dart2js_native/native_exception2_test.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_exception_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_exceptions1_frog_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation2_test.dart View 3 chunks +12 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation3_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation4_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation5_test.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation6_test.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_name_test.dart View 3 chunks +4 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_optimization_test.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_rename_1_frog_test.dart View 3 chunks +6 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_rename_2_frog_test.dart View 3 chunks +6 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_library_same_name_used_frog_test.dart View 4 chunks +1 line, -6 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_inlining_test.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename1_frog_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename2_frog_test.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename3_frog_test.dart View 3 chunks +6 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_with_keyword_name_test.dart View 2 chunks +6 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_mirror_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_missing_method1_frog_test.dart View 1 chunk +12 lines, -15 lines 0 comments Download
M tests/compiler/dart2js_native/native_missing_method2_frog_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_field_test.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_multiple2_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_multiple3_test.dart View 3 chunks +2 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_multiple_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_with_plain_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_named_constructors3_frog_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception2_frog_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception3_frog_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception4_frog_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception5_frog_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception_frog_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_novel_html_test.dart View 2 chunks +8 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_null_closure_frog_test.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_null_frog_test.dart View 3 chunks +4 lines, -25 lines 0 comments Download
M tests/compiler/dart2js_native/native_property_frog_test.dart View 3 chunks +3 lines, -11 lines 0 comments Download
D tests/compiler/dart2js_native/native_testing.dart View 1 chunk +0 lines, -50 lines 0 comments Download
M tests/compiler/dart2js_native/native_to_string_frog_test.dart View 1 chunk +3 lines, -11 lines 0 comments Download
M tests/compiler/dart2js_native/native_use_native_name_in_table_frog_test.dart View 2 chunks +10 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_native/native_window1_frog_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_window2_frog_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_wrapping_function3_frog_test.dart View 3 chunks +8 lines, -10 lines 0 comments Download
M tests/compiler/dart2js_native/native_wrapping_function_frog_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/oddly_named_fields_test.dart View 2 chunks +1 line, -3 lines 0 comments Download
M tests/compiler/dart2js_native/runtimetype_test.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/static_methods_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_1_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_2_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_3_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_4_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_5_test.dart View 2 chunks +39 lines, -37 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_constructor_1_test.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_constructor_2_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/subclassing_super_call_test.dart View 6 chunks +30 lines, -27 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_super_field_1_test.dart View 3 chunks +8 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_super_field_2_test.dart View 3 chunks +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_type_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/super_call_test.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/super_property_test.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/type_error_decode_test.dart View 2 chunks +5 lines, -11 lines 0 comments Download
M tests/compiler/dart2js_native/undefined_bailout_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/uninstantiated_type_parameter_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/html/html.status View 2 chunks +1 line, -4 lines 0 comments Download
D tests/html/js_interop_constructor_name_test.dart View 1 chunk +0 lines, -98 lines 0 comments Download
D tests/html/js_interop_constructor_name_test.html View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/html/js_interop_constructor_name_test_js.js View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sra1
4 years, 2 months ago (2016-09-30 20:27:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
74deaad759bfbacbdf55bd47e4f175a4c15ac571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698