Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: ui/wm/core/window_util.h

Issue 2383263002: Generalize layer mirroring for phantom windows (Closed)
Patch Set: Revert layer renaming Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/wm/core/window_util.h
diff --git a/ui/wm/core/window_util.h b/ui/wm/core/window_util.h
index eac3879823d3e6c41dad0b1152baf0f80914b72e..6708a54ea3dc0ea345a0084be086a730a13d9ff1 100644
--- a/ui/wm/core/window_util.h
+++ b/ui/wm/core/window_util.h
@@ -17,7 +17,6 @@ class Window;
namespace ui {
class Layer;
-class LayerDelegate;
class LayerOwner;
class LayerTreeOwner;
}
@@ -37,30 +36,18 @@ WM_EXPORT aura::Window* GetActivatableWindow(aura::Window* window);
// determination.
WM_EXPORT aura::Window* GetToplevelWindow(aura::Window* window);
-// A factory method to create a delegate for recreated layers.
-class WM_EXPORT LayerDelegateFactory {
- public:
- virtual ~LayerDelegateFactory() = default;
- // |original_layer| may already be deleted by the time the new
- // delegate is created, so if the new delegate has to access it
- // later, it is the new delegate's responsibility to make sure the
- // original layer/delegate is alive.
- virtual ui::LayerDelegate* CreateDelegate(ui::Layer* new_layer,
- ui::Layer* original_layer) = 0;
-};
-
// Returns the existing Layer for |root| (and all its descendants) and creates
// a new layer for |root| and all its descendants. This is intended for
// animations that want to animate between the existing visuals and a new state.
//
// As a result of this |root| has freshly created layers, meaning the layers
// have not yet been painted to.
-//
-// When a non null |delegate_factory| is passed, it will be used to
-// create a delegate for an old layer which had its own delegate.
WM_EXPORT std::unique_ptr<ui::LayerTreeOwner> RecreateLayers(
- ui::LayerOwner* root,
- LayerDelegateFactory* delegate_factory);
+ ui::LayerOwner* root);
+
+// Returns a layer tree that mirrors |root|. Used for live window previews.
+WM_EXPORT std::unique_ptr<ui::LayerTreeOwner> MirrorLayers(
+ ui::LayerOwner* root, bool sync_bounds);
sky 2016/10/19 19:27:14 Document what sync_bounds means (you can just say
Dominik Laskowski 2016/10/19 22:46:38 Done.
// Convenience functions that get the TransientWindowManager for the window and
// redirect appropriately. These are preferable to calling functions on

Powered by Google App Engine
This is Rietveld 408576698