Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2383203003: Add an analysis option to disable cache flushing. (Closed)

Created:
4 years, 2 months ago by Paul Berry
Modified:
4 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an analysis option to disable cache flushing. This improves the analysis speed of large projects by as much as 20%. It also can be used to work around cache flushing bugs. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/4b2bf4d6a00e3688e34b3aabb4e8af6443b7587e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
M pkg/analyzer/lib/src/context/cache.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +15 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 3 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/test/options_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 2 months ago (2016-09-30 21:08:30 UTC) #2
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-09-30 21:34:15 UTC) #3
Paul Berry
4 years, 2 months ago (2016-10-01 13:41:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4b2bf4d6a00e3688e34b3aabb4e8af6443b7587e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698