Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2383203002: Mark SequencedWorkerPool::GetWorkerPoolForCurrentThread() as deprecated. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
danakj, gab
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark SequencedWorkerPool::GetWorkerPoolForCurrentThread() as deprecated. This methods does not work when SequencedWorkerPool is redirected to TaskScheduler (always returns nullptr). The only remaining use is in base/threading/sequenced_task_runner_handle.cc (which uses another way to get the current SequencedTaskRunner when redirection to TaskScheduler is enabled). BUG=622400 Committed: https://crrev.com/3be8af75b2f307116aabebc05dd92b5169145f58 Cr-Commit-Position: refs/heads/master@{#422238}

Patch Set 1 #

Patch Set 2 : self-review #

Total comments: 3

Patch Set 3 : CR danakj/gab #3-4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M base/threading/sequenced_worker_pool.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
fdoray
PTAL
4 years, 2 months ago (2016-09-30 19:04:55 UTC) #2
danakj
https://codereview.chromium.org/2383203002/diff/20001/base/threading/sequenced_worker_pool.h File base/threading/sequenced_worker_pool.h (right): https://codereview.chromium.org/2383203002/diff/20001/base/threading/sequenced_worker_pool.h#newcode173 base/threading/sequenced_worker_pool.h:173: // DEPRECATED. The only remaining use is in Can ...
4 years, 2 months ago (2016-09-30 19:14:55 UTC) #3
gab
https://codereview.chromium.org/2383203002/diff/20001/base/threading/sequenced_worker_pool.h File base/threading/sequenced_worker_pool.h (right): https://codereview.chromium.org/2383203002/diff/20001/base/threading/sequenced_worker_pool.h#newcode173 base/threading/sequenced_worker_pool.h:173: // DEPRECATED. The only remaining use is in On ...
4 years, 2 months ago (2016-09-30 19:24:01 UTC) #4
fdoray
PTAnL https://codereview.chromium.org/2383203002/diff/20001/base/threading/sequenced_worker_pool.h File base/threading/sequenced_worker_pool.h (right): https://codereview.chromium.org/2383203002/diff/20001/base/threading/sequenced_worker_pool.h#newcode173 base/threading/sequenced_worker_pool.h:173: // DEPRECATED. The only remaining use is in ...
4 years, 2 months ago (2016-09-30 19:28:55 UTC) #5
gab
lgtm
4 years, 2 months ago (2016-09-30 19:30:33 UTC) #6
danakj
LGTM
4 years, 2 months ago (2016-09-30 20:19:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383203002/40001
4 years, 2 months ago (2016-09-30 20:25:35 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-30 22:15:45 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 22:17:48 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3be8af75b2f307116aabebc05dd92b5169145f58
Cr-Commit-Position: refs/heads/master@{#422238}

Powered by Google App Engine
This is Rietveld 408576698