Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js

Issue 2383183002: DevTools: fix scrolling in audits (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/audits/auditsPanel.css » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 }, 125 },
126 126
127 /** 127 /**
128 * @param {!Array.<!WebInspector.AuditCategoryResult>} categoryResults 128 * @param {!Array.<!WebInspector.AuditCategoryResult>} categoryResults
129 */ 129 */
130 showResults: function(categoryResults) 130 showResults: function(categoryResults)
131 { 131 {
132 if (!categoryResults._resultLocation) { 132 if (!categoryResults._resultLocation) {
133 categoryResults.sort((a, b) => (a.title || "").localeCompare(b.title || "")); 133 categoryResults.sort((a, b) => (a.title || "").localeCompare(b.title || ""));
134 var resultView = WebInspector.viewManager.createStackLocation(); 134 var resultView = WebInspector.viewManager.createStackLocation();
135 resultView.widget().element.classList.add("audit-result-view");
135 for (var i = 0; i < categoryResults.length; ++i) 136 for (var i = 0; i < categoryResults.length; ++i)
136 resultView.showView(new WebInspector.AuditCategoryResultPane(cat egoryResults[i])); 137 resultView.showView(new WebInspector.AuditCategoryResultPane(cat egoryResults[i]));
137 categoryResults._resultLocation = resultView; 138 categoryResults._resultLocation = resultView;
138 } 139 }
139 this.visibleView = categoryResults._resultLocation.widget(); 140 this.visibleView = categoryResults._resultLocation.widget();
140 }, 141 },
141 142
142 showLauncherView: function() 143 showLauncherView: function()
143 { 144 {
144 this.visibleView = this._launcherView; 145 this.visibleView = this._launcherView;
(...skipping 409 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 } 555 }
555 556
556 // Contributed audit rules should go into this namespace. 557 // Contributed audit rules should go into this namespace.
557 WebInspector.AuditRules = {}; 558 WebInspector.AuditRules = {};
558 559
559 /** 560 /**
560 * Contributed audit categories should go into this namespace. 561 * Contributed audit categories should go into this namespace.
561 * @type {!Object.<string, function(new:WebInspector.AuditCategory)>} 562 * @type {!Object.<string, function(new:WebInspector.AuditCategory)>}
562 */ 563 */
563 WebInspector.AuditCategories = {}; 564 WebInspector.AuditCategories = {};
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/audits/auditsPanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698