infra/bots/recipes/upload_dm_results.py - Issue 2383163002: upload_dm_results: Remove JSON validation step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipes/upload_dm_results.py

Issue 2383163002: upload_dm_results: Remove JSON validation step (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra/bots/recipes/upload_dm_results.py

diff --git a/infra/bots/recipes/upload_dm_results.py b/infra/bots/recipes/upload_dm_results.py

index 49dc2ac505adcde1f921bd49461878f08af1483f..6d1b0eacd0016007709c69aae4e91a17b927e8a7 100644

--- a/infra/bots/recipes/upload_dm_results.py

+++ b/infra/bots/recipes/upload_dm_results.py

@@ -42,11 +42,8 @@ def RunSteps(api):

results_dir = api.path['cwd'].join('dm')

- # Validate the JSON file.

- json_file = results_dir.join(DM_JSON)

- api.json.read('validate dm.json', json_file)

# Move dm.json and verbose.log to their own directory.

+ json_file = results_dir.join(DM_JSON)

log_file = results_dir.join(VERBOSE_LOG)

tmp_dir = api.path['cwd'].join('tmp_upload')

api.shutil.makedirs('tmp dir', tmp_dir, infra_step=True)

« no previous file with comments | « no previous file | infra/bots/recipes/upload_dm_results.expected/normal_bot.json » ('j') | no next file with comments »