infra/bots/recipes/upload_dm_results.expected/recipe_with_gerrit_patch.json - Issue 2383163002: upload_dm_results: Remove JSON validation step

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: infra/bots/recipes/upload_dm_results.expected/recipe_with_gerrit_patch.json

Issue 2383163002: upload_dm_results: Remove JSON validation step (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « infra/bots/recipes/upload_dm_results.expected/normal_bot.json ('k') | infra/bots/recipes/upload_dm_results.expected/trybot.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

7 "[CWD]/dm/dm.json",

8 "/path/to/tmp/json"

9 ],

10 "name": "validate dm.json",

11 "~followup_annotations": [

12 "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",

13 "@@@STEP_LOG_END@json.output (invalid)@@@"

14 ]

15 },

16 {

17 "cmd": [

18 "python",

19 "-u",

20 "\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os. path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n",	6 "\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os. path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n",

21 "[CWD]/tmp_upload",	7 "[CWD]/tmp_upload",

22 "511"	8 "511"

23 ],	9 ],

24 "name": "makedirs tmp dir",	10 "name": "makedirs tmp dir",

25 "~followup_annotations": [	11 "~followup_annotations": [

26 "@@@STEP_LOG_LINE@python.inline@@@@",	12 "@@@STEP_LOG_LINE@python.inline@@@@",

27 "@@@STEP_LOG_LINE@python.inline@import sys, os@@@",	13 "@@@STEP_LOG_LINE@python.inline@import sys, os@@@",

28 "@@@STEP_LOG_LINE@python.inline@path = sys.argv[1]@@@",	14 "@@@STEP_LOG_LINE@python.inline@path = sys.argv[1]@@@",

29 "@@@STEP_LOG_LINE@python.inline@mode = int(sys.argv[2])@@@",	15 "@@@STEP_LOG_LINE@python.inline@mode = int(sys.argv[2])@@@",

(...skipping 86 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
116 "gs://skia-infra-gm/trybot/dm-json-v1/2012/05/14/12/abc123/Test-Ubuntu-GCC -GCE-CPU-AVX2-x86_64-Debug-Trybot/1337018001/2100/2"	102 "gs://skia-infra-gm/trybot/dm-json-v1/2012/05/14/12/abc123/Test-Ubuntu-GCC -GCE-CPU-AVX2-x86_64-Debug-Trybot/1337018001/2100/2"

117 ],	103 ],

118 "name": "upload JSON and logs"	104 "name": "upload JSON and logs"

119 },	105 },

120 {	106 {

121 "name": "$result",	107 "name": "$result",

122 "recipe_result": null,	108 "recipe_result": null,

123 "status_code": 0	109 "status_code": 0

124 }	110 }

125 ]	111 ]

OLD	NEW