third_party/WebKit/Source/platform/scroll/ScrollableArea.h - Issue 2383113003: Refactor ScrollableArea::setScrollPosition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 2383113003: Refactor ScrollableArea::setScrollPosition. (Closed)

Patch Set: nits and rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableArea.h b/third_party/WebKit/Source/platform/scroll/ScrollableArea.h

index 0245214900a9b1499088e1ff99862ccd3bd12bd0..746c468074b2327c8c93b3d57bd344f32e0fa95f 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollableArea.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollableArea.h

@@ -380,7 +380,7 @@ class PLATFORM_EXPORT ScrollableArea : public GarbageCollectedMixin {

// This function should be overriden by subclasses to perform the actual

// scroll of the content.

- virtual void setScrollOffset(const DoublePoint& offset, ScrollType) = 0;

+ virtual void setScrollOffset(const DoublePoint&, ScrollType) = 0;

virtual int lineStep(ScrollbarOrientation) const;

virtual int pageStep(ScrollbarOrientation) const;