third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp - Issue 2383113003: Refactor ScrollableArea::setScrollPosition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp

Issue 2383113003: Refactor ScrollableArea::setScrollPosition. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp

diff --git a/third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp b/third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp

index b0502a1293932dd0275fe9d3f3fd0a3d17a4f587..a175c1435fb7089dc6c36fd728eeef14efe6116f 100644

--- a/third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp

+++ b/third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp

@@ -78,7 +78,7 @@ class ScrollableAreaStub : public GarbageCollectedFinalized<ScrollableAreaStub>,

m_viewportSize(viewportSize),

m_contentsSize(contentsSize) {}

- void setScrollOffset(const DoublePoint& offset, ScrollType) override {

+ void updateScrollPosition(const DoublePoint& offset, ScrollType) override {

m_scrollPosition = offset;

}

bool shouldUseIntegerScrollOffset() const override { return true; }