Allow client nodes to gain ChromeVox range.

Allow client nodes to gain ChromeVox range.

Notificaiton center now fires a focus event on a view that has no role (i.e. a client node). Allow for this so that we pick up on the window ax obj's name "notification center" and override client output to be $name (avoiding the role which provides no value).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=643995
TEST=alt+shift+n

Committed: https://crrev.com/f03a5fd8d49e998cf383566291d96148cdba5773
Cr-Commit-Position: refs/heads/master@{#422607}

[David Tseng, 2016-09-30 19:41:02]

Description was changed from

==========
Allow client nodes to gain ChromeVox range.
==========

to

==========
Allow client nodes to gain ChromeVox range.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-09-30 19:43:05]

Description was changed from

==========
Allow client nodes to gain ChromeVox range.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Allow client nodes to gain ChromeVox range.

Notificaiton center now fires a focus event on a view that has no role (i.e. a
client node). Allow for this so that we pick up on the window ax obj's name
"notification center" and override client output to be $name (avoiding the role
which provides no value).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=643995
TEST=alt+shift+n
==========

[David Tseng, 2016-09-30 19:43:06]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-10-03 18:29:10]

lgtm

This is fine, but is there a bug filed to fix the role,
though?

[David Tseng, 2016-10-03 22:36:34]

Long story. In short,

https://bugs.chromium.org/p/chromium/issues/detail?id=620801
where I tried to get the first item focused, but a bad looking focus
highlight resulted in a revert.


On Mon, Oct 3, 2016 at 11:29 AM, <dmazzoni@chromium.org> wrote:

> lgtm
>
> This is fine, but is there a bug filed to fix the role,
> though?
>
>
> https://codereview.chromium.org/2383103003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2016-10-03 22:37:01]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-10-03 22:37:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 23:57:31]

Description was changed from

==========
Allow client nodes to gain ChromeVox range.

Notificaiton center now fires a focus event on a view that has no role (i.e. a
client node). Allow for this so that we pick up on the window ax obj's name
"notification center" and override client output to be $name (avoiding the role
which provides no value).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=643995
TEST=alt+shift+n
==========

to

==========
Allow client nodes to gain ChromeVox range.

Notificaiton center now fires a focus event on a view that has no role (i.e. a
client node). Allow for this so that we pick up on the window ax obj's name
"notification center" and override client output to be $name (avoiding the role
which provides no value).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=643995
TEST=alt+shift+n
==========

[commit-bot: I haz the power, 2016-10-03 23:57:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 00:00:18]

Description was changed from

==========
Allow client nodes to gain ChromeVox range.

Notificaiton center now fires a focus event on a view that has no role (i.e. a
client node). Allow for this so that we pick up on the window ax obj's name
"notification center" and override client output to be $name (avoiding the role
which provides no value).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=643995
TEST=alt+shift+n
==========

to

==========
Allow client nodes to gain ChromeVox range.

Notificaiton center now fires a focus event on a view that has no role (i.e. a
client node). Allow for this so that we pick up on the window ax obj's name
"notification center" and override client output to be $name (avoiding the role
which provides no value).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=643995
TEST=alt+shift+n

Committed: https://crrev.com/f03a5fd8d49e998cf383566291d96148cdba5773
Cr-Commit-Position: refs/heads/master@{#422607}
==========

[commit-bot: I haz the power, 2016-10-04 00:00:19]

Patchset 1 (id:??) landed as
https://crrev.com/f03a5fd8d49e998cf383566291d96148cdba5773
Cr-Commit-Position: refs/heads/master@{#422607}