Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2383043003:
DevTools: archive content shell (Closed)
|
Created:
4 years, 2 months ago by chenwilliam Modified:
4 years, 2 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: archive content shell
Creates an archive of the content shell for each desktop platform.
This will enable external contributors to use a precompiled
content shell to run devtools layout tests (and possibly others).
The original patch broke the chrome archive because the FILES.cfg parser
couldn't support archiving the same file in multiple archives.
I've updated the parser logic in this CL:
https://codereview.chromium.org/2402423002/
BUG=654486
Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf
Committed: https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35
Committed: https://crrev.com/42fed477dcd99e0df2ef6415fbfcb10dfd3d2ac9
Cr-Original-Original-Commit-Position: refs/heads/master@{#423195}
Cr-Original-Commit-Position: refs/heads/master@{#424514}
Cr-Commit-Position: refs/heads/master@{#424771}
Patch Set 1 #
Messages
Total messages: 27 (12 generated)
chenwilliam@chromium.org changed reviewers: + kerz@chromium.org
PTAL, thanks.
kerz@google.com changed reviewers: + kerz@google.com
lgtm
lgtm
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). I manually verified these files are needed to run devtools layout tests with the content shell. BUG=none ========== to ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). I manually verified these files are needed to run devtools layout tests with the content shell. BUG=none Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Cr-Commit-Position: refs/heads/master@{#423195} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Cr-Commit-Position: refs/heads/master@{#423195}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2399173002/ by chenwilliam@chromium.org. The reason for reverting is: This broke the chromium build archive crbug.com/653406.
Message was sent while issue was closed.
Description was changed from ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). I manually verified these files are needed to run devtools layout tests with the content shell. BUG=none Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Cr-Commit-Position: refs/heads/master@{#423195} ========== to ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG=654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Cr-Commit-Position: refs/heads/master@{#423195} ==========
Updated description.
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG=654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Cr-Commit-Position: refs/heads/master@{#423195} ========== to ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG=654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Cr-Commit-Position: refs/heads/master@{#423195} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG=654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Cr-Commit-Position: refs/heads/master@{#423195} ========== to ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG=654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Committed: https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35 Cr-Original-Commit-Position: refs/heads/master@{#423195} Cr-Commit-Position: refs/heads/master@{#424514} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35 Cr-Commit-Position: refs/heads/master@{#424514}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2412763002/ by chenwilliam@chromium.org. The reason for reverting is: Need to revert this b/c this CL is getting reverted: https://codereview.chromium.org/2407183003/.
Message was sent while issue was closed.
Description was changed from ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG=654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Committed: https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35 Cr-Original-Commit-Position: refs/heads/master@{#423195} Cr-Commit-Position: refs/heads/master@{#424514} ========== to ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG=654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Committed: https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35 Cr-Original-Commit-Position: refs/heads/master@{#423195} Cr-Commit-Position: refs/heads/master@{#424514} ==========
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG=654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Committed: https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35 Cr-Original-Commit-Position: refs/heads/master@{#423195} Cr-Commit-Position: refs/heads/master@{#424514} ========== to ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG=654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Committed: https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35 Cr-Original-Commit-Position: refs/heads/master@{#423195} Cr-Commit-Position: refs/heads/master@{#424514} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG=654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Committed: https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35 Cr-Original-Commit-Position: refs/heads/master@{#423195} Cr-Commit-Position: refs/heads/master@{#424514} ========== to ========== DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG=654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Committed: https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35 Committed: https://crrev.com/42fed477dcd99e0df2ef6415fbfcb10dfd3d2ac9 Cr-Original-Original-Commit-Position: refs/heads/master@{#423195} Cr-Original-Commit-Position: refs/heads/master@{#424514} Cr-Commit-Position: refs/heads/master@{#424771} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/42fed477dcd99e0df2ef6415fbfcb10dfd3d2ac9 Cr-Commit-Position: refs/heads/master@{#424771} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
