Issue 238303004: Remove DOMImplementation.createCSSStyleSheet()

Issue 238303004: Remove DOMImplementation.createCSSStyleSheet() (Closed)

Created:
6 years, 8 months ago by philipj_slow

Modified:
6 years, 8 months ago

Reviewers:
jochen (gone - plz use gerrit), eseidel

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, watchdog-blink-watchlist_google.com, Inactive, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove DOMImplementation.createCSSStyleSheet() Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/uDjkuGA9gQs/zytnzJ6WryYJ Without createCSSStyleSheet() it becomes a bit more difficult to create a CSSStyleSheet which is not reachable from elsewhere, but it's still possible. Note that the updated tests still do fail, the reason being explained in ~CSSStyleSheet(). BUG=363561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171766

Patch Set 1 #

Patch Set 2 : update tests #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -28 lines)			Patch
M	LayoutTests/fast/dom/StyleSheet/gc-parent-rule.html	View	1	1 chunk	+12 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/StyleSheet/gc-parent-rule-expected.txt	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/StyleSheet/gc-parent-stylesheet.html	View	1	1 chunk	+12 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/StyleSheet/gc-parent-stylesheet-expected.txt	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/css/StyleSheetContents.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/dom/DOMImplementation.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/dom/DOMImplementation.cpp	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	Source/core/dom/DOMImplementation.idl	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/frame/UseCounter.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/frame/UseCounter.cpp	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/238303004/20001

6 years, 8 months ago (2014-04-16 11:44:34 UTC) #5

Message was sent while issue was closed.

Change committed as 171766

Expand Messages | Collapse Messages