Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 238303002: Adds height:auto to images to prevent vertical stretching.

Created:
6 years, 8 months ago by danielj41
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adds height:auto to images to prevent vertical stretching. Recompiles css and adds a config file for compiling. BUG=341916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
A chrome/common/extensions/docs/config.rb View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/static/css/out/site.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/sass/_layout.scss View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
danielj41
Adds height:auto to img to prevent vertical stretching.
6 years, 8 months ago (2014-04-15 00:17:48 UTC) #1
jshumway
On 2014/04/15 00:17:48, danielj41 wrote: > Adds height:auto to img to prevent vertical stretching. The ...
6 years, 8 months ago (2014-04-15 17:53:24 UTC) #2
danielj41
I added height:auto to img to prevent images from getting stretched vertically. Could you please ...
6 years, 8 months ago (2014-04-15 18:10:02 UTC) #3
danielj41
mkearney1@, can you please check if I compiled the CSS correctly?
6 years, 7 months ago (2014-04-28 23:39:27 UTC) #4
danielj41
mangini@, Is there a configuration file for compiling the css? I made one that seems ...
6 years, 7 months ago (2014-05-07 23:04:24 UTC) #5
Renato Mangini (chromium)
6 years, 7 months ago (2014-05-07 23:13:39 UTC) #6
On 2014/05/07 23:04:24, danielj41 wrote:
> mangini@,
> Is there a configuration file for compiling the css? I made one that seems to
> generate the correct css, but I'm not sure if I'm doing it correctly.

Currently, you can't upload a config.rb in your CL. If you do, Chromium
precommit checks will reject it (depot tools doesn't properly handle rb
extension).

The config.rb I've been using is below (run compass compile from the docs
directory):

-----
environment = :production
firesass = false
http_path = "/"
css_dir = "static/css/out"
sass_dir = "static/sass"
images_dir = "static/images"
javascripts_dir = "static/js"
output_style = (environment == :development) ? :expanded : :compressed
relative_assets = true
sass_options = (environment == :development) ? {:debug_info => false} \
    : {:always_update => true}
-----

Powered by Google App Engine
This is Rietveld 408576698