Remove some non-essential StringPiece->std::string conversion in base/

Remove some non-essential StringPiece->std::string conversion in base/

StringValue already accepts StringPiece as constructor.

Get/SetWithoutPathExpansion readily takes StringPiece, so don't
covert StringPiece -> std::string then back to StringPiece for these.

Searching token can be done within StringPieces, without needing
to create temporary strings.

BUG=None
Test=None, internal change.

Committed: https://crrev.com/1cbc7b45b59471142424f8a64c0ef40daa8be0e5
Cr-Commit-Position: refs/heads/master@{#422620}

[lazyboy, 2016-10-01 04:44:02]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 04:44:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lazyboy, 2016-10-01 04:57:18]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 04:57:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lazyboy, 2016-10-03 17:30:49]

Description was changed from

==========
Remove some non-essential StringPiece->std::string conversion in values.cc

BUG=
==========

to

==========
Remove some non-essential StringPiece->std::string conversion in base/

StringValue already accepts StringPiece as constructor.

Get/SetWithoutPathExpansion readily takes StringPiece, so don't
covert StringPiece -> std::string then back to StringPiece for these.

Searching token can be done within StringPieces, without needing
to create temporary strings.

BUG=None
Test=None, internal change.
==========

[lazyboy, 2016-10-03 17:35:55]

lazyboy@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-10-03 19:56:55]

Nice find =)

LGTM with a nit

https://codereview.chromium.org/2383013004/diff/40001/base/values.cc
File base/values.cc (right):

https://codereview.chromium.org/2383013004/diff/40001/base/values.cc#newcode396
base/values.cc:396: delimiter_position != std::string::npos;
Nit: StringPiece::npos

[lazyboy, 2016-10-03 20:51:09]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[lazyboy, 2016-10-03 20:51:15]

https://codereview.chromium.org/2383013004/diff/40001/base/values.cc
File base/values.cc (right):

https://codereview.chromium.org/2383013004/diff/40001/base/values.cc#newcode396
base/values.cc:396: delimiter_position != std::string::npos;
On 2016/10/03 19:56:54, dcheng wrote:
> Nit: StringPiece::npos

Done.

[commit-bot: I haz the power, 2016-10-03 20:51:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 23:30:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 23:30:51]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2016-10-04 00:11:08]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2016-10-04 00:11:08]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2383013004/#ps60001
(title: "address comments")

[commit-bot: I haz the power, 2016-10-04 00:12:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:19:16]

Description was changed from

==========
Remove some non-essential StringPiece->std::string conversion in base/

StringValue already accepts StringPiece as constructor.

Get/SetWithoutPathExpansion readily takes StringPiece, so don't
covert StringPiece -> std::string then back to StringPiece for these.

Searching token can be done within StringPieces, without needing
to create temporary strings.

BUG=None
Test=None, internal change.
==========

to

==========
Remove some non-essential StringPiece->std::string conversion in base/

StringValue already accepts StringPiece as constructor.

Get/SetWithoutPathExpansion readily takes StringPiece, so don't
covert StringPiece -> std::string then back to StringPiece for these.

Searching token can be done within StringPieces, without needing
to create temporary strings.

BUG=None
Test=None, internal change.
==========

[commit-bot: I haz the power, 2016-10-04 00:19:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-04 00:21:20]

Description was changed from

==========
Remove some non-essential StringPiece->std::string conversion in base/

StringValue already accepts StringPiece as constructor.

Get/SetWithoutPathExpansion readily takes StringPiece, so don't
covert StringPiece -> std::string then back to StringPiece for these.

Searching token can be done within StringPieces, without needing
to create temporary strings.

BUG=None
Test=None, internal change.
==========

to

==========
Remove some non-essential StringPiece->std::string conversion in base/

StringValue already accepts StringPiece as constructor.

Get/SetWithoutPathExpansion readily takes StringPiece, so don't
covert StringPiece -> std::string then back to StringPiece for these.

Searching token can be done within StringPieces, without needing
to create temporary strings.

BUG=None
Test=None, internal change.

Committed: https://crrev.com/1cbc7b45b59471142424f8a64c0ef40daa8be0e5
Cr-Commit-Position: refs/heads/master@{#422620}
==========

[commit-bot: I haz the power, 2016-10-04 00:21:21]

Patchset 4 (id:??) landed as
https://crrev.com/1cbc7b45b59471142424f8a64c0ef40daa8be0e5
Cr-Commit-Position: refs/heads/master@{#422620}