Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2383003002: [test262] Temporarily disable Date tests that fail depending on the timezone. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test262] Temporarily disable Date tests that fail depending on the timezone. BUG=v8:5449 R=machenbach@chromium.org TBR=littledan@chromium.org NOTRY=true Committed: https://crrev.com/e500144780f092da7ca2e9c42c4fa33b31b6cad8 Cr-Commit-Position: refs/heads/master@{#39903}

Patch Set 1 #

Patch Set 2 : Add link. #

Total comments: 1

Patch Set 3 : Comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/test262/test262.status View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
neis
4 years, 2 months ago (2016-09-30 07:19:39 UTC) #1
Michael Achenbach
lgtm with nit https://codereview.chromium.org/2383003002/diff/20001/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/2383003002/diff/20001/test/test262/test262.status#newcode38 test/test262/test262.status:38: # Date tests that fail in ...
4 years, 2 months ago (2016-09-30 07:38:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383003002/20001
4 years, 2 months ago (2016-09-30 08:26:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383003002/40001
4 years, 2 months ago (2016-09-30 08:27:36 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-30 08:29:54 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 08:30:09 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e500144780f092da7ca2e9c42c4fa33b31b6cad8
Cr-Commit-Position: refs/heads/master@{#39903}

Powered by Google App Engine
This is Rietveld 408576698