Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23830007: Support byte range requests when routing resource requests directly through the browser process. (Closed)

Created:
7 years, 3 months ago by jam
Modified:
4 years, 7 months ago
Reviewers:
jschuh, ananta
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Support byte range requests when routing resource requests directly through the browser process. This also fixes a number of issues I saw when testing Netflix: -fix http status header not reaching plugin -send a Content-Type header if one isn't specified by the plugin for POSTs -null check info->headers, needed for data: URLs This doesn't support responding to 200s after a byte-range request. I'm gathering stats now to see how often this happens. BUG=286074 R=ananta@chromium.org, jschuh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223483

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : take out temporary code enabling by default #

Patch Set 4 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -169 lines) Patch
M content/browser/child_process_security_policy_impl.cc View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_url_fetcher.h View 1 2 3 3 chunks +6 lines, -3 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 1 2 3 9 chunks +142 lines, -20 lines 0 comments Download
M content/child/npapi/webplugin.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/npapi/webplugin_delegate.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/plugin_messages.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M content/plugin/webplugin_proxy.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/plugin/webplugin_proxy.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 1 2 3 4 chunks +16 lines, -2 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 2 3 8 chunks +23 lines, -27 lines 0 comments Download
M webkit/child/weburlloader_impl.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M webkit/child/weburlloader_impl.cc View 1 2 3 2 chunks +108 lines, -109 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
7 years, 3 months ago (2013-09-16 18:03:33 UTC) #1
ananta
lgtm https://codereview.chromium.org/23830007/diff/29001/content/child/npapi/plugin_url_fetcher.cc File content/child/npapi/plugin_url_fetcher.cc (right): https://codereview.chromium.org/23830007/diff/29001/content/child/npapi/plugin_url_fetcher.cc#newcode240 content/child/npapi/plugin_url_fetcher.cc:240: // TODO: should we handle this case? We ...
7 years, 3 months ago (2013-09-16 18:35:41 UTC) #2
jam
https://codereview.chromium.org/23830007/diff/29001/content/child/npapi/plugin_url_fetcher.cc File content/child/npapi/plugin_url_fetcher.cc (right): https://codereview.chromium.org/23830007/diff/29001/content/child/npapi/plugin_url_fetcher.cc#newcode240 content/child/npapi/plugin_url_fetcher.cc:240: // TODO: should we handle this case? We used ...
7 years, 3 months ago (2013-09-16 19:31:33 UTC) #3
jam
+jschuh for trivial messages.h change
7 years, 3 months ago (2013-09-16 20:33:41 UTC) #4
jschuh
ipc security lgtm. no security impact.
7 years, 3 months ago (2013-09-16 21:17:36 UTC) #5
Mahmednoome
4 years, 7 months ago (2016-05-02 22:07:56 UTC) #6
Message was sent while issue was closed. 
On 2013/09/16 21:17:36, jschuh (very slow) wrote:
> <font><font>LGTM الأمن التصنيف الدولي للبراءات. </font><font>أي تأثير
الأمنية.</font></font>

taimforg23830007

Powered by Google App Engine
This is Rietveld 408576698