Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Issue 2382993003: Video player: Reset the focus on entering fullscree mode. (Closed)

Created:
4 years, 2 months ago by fukino
Modified:
4 years, 2 months ago
Reviewers:
harukam
CC:
chromium-reviews, posciak+watch_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Video player: Reset the focus on entering fullscree mode. To use spacebar for pause/play, we need to reset the focus on entering fullscreen mode. Without this code, spacebar will toggle fullscreen state and it is not consistent with Youtube. BUG=649926 TEST=manually tested CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c16ace9166eaa0dc45f613c74a8f81b21c36c79f Cr-Commit-Position: refs/heads/master@{#422076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/file_manager/video_player/js/media_controls.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
fukino
4 years, 2 months ago (2016-09-30 08:13:34 UTC) #3
harukam
lgtm:-D
4 years, 2 months ago (2016-09-30 10:39:48 UTC) #8
fukino
Thanks!
4 years, 2 months ago (2016-09-30 10:40:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382993003/1
4 years, 2 months ago (2016-09-30 10:41:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 10:45:49 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 10:47:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c16ace9166eaa0dc45f613c74a8f81b21c36c79f
Cr-Commit-Position: refs/heads/master@{#422076}

Powered by Google App Engine
This is Rietveld 408576698