Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/url_request/url_request_unittest.cc

Issue 2382983002: Remove the last of the TLS fallback code. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/socket/ssl_client_socket_impl.cc ('K') | « net/ssl/ssl_config.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 328d53b81091a6faab351c398c38a2129ca8acc9..8d41200ddba373ef5c3d4c54d8b18ff617a0af97 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -8758,15 +8758,6 @@ class HTTPSFallbackTest : public testing::Test {
base::RunLoop().Run();
}
- void ExpectConnection(int version) {
- EXPECT_EQ(1, delegate_.response_started_count());
- EXPECT_NE(0, delegate_.bytes_received());
- EXPECT_EQ(version, SSLConnectionStatusToVersion(
- request_->ssl_info().connection_status));
- EXPECT_TRUE(request_->ssl_info().connection_status &
- SSL_CONNECTION_VERSION_FALLBACK);
mmenke 2016/10/03 16:01:03 Can we remove SSL_CONNECTION_VERSION_FALLBACK?
davidben 2016/10/03 19:09:24 Done.
- }
-
void ExpectFailure(int error) {
EXPECT_EQ(1, delegate_.response_started_count());
EXPECT_EQ(error, delegate_.request_status());
« net/socket/ssl_client_socket_impl.cc ('K') | « net/ssl/ssl_config.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698