Convert WebSecurityOrigin -> GURL without re-parsing the url

third_party/WebKit/Source/modules/storage/StorageNamespace.cpp

Index: third_party/WebKit/Source/modules/storage/StorageNamespace.cpp
diff --git a/third_party/WebKit/Source/modules/storage/StorageNamespace.cpp b/third_party/WebKit/Source/modules/storage/StorageNamespace.cpp
index 66a55cac4aeb6931f7770549fca55c2b181cda60..1023768ac54017f5ca5fcec17105caa292ae5a50 100644
--- a/third_party/WebKit/Source/modules/storage/StorageNamespace.cpp
+++ b/third_party/WebKit/Source/modules/storage/StorageNamespace.cpp
@@ -28,6 +28,7 @@
 #include "modules/storage/StorageArea.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "public/platform/Platform.h"
+#include "public/platform/WebSecurityOrigin.h"
 #include "public/platform/WebStorageArea.h"
 #include "public/platform/WebStorageNamespace.h"
 #include "wtf/PtrUtil.h"
@@ -47,13 +48,15 @@ StorageArea* StorageNamespace::localStorageArea(SecurityOrigin* origin) {
   if (!localStorageNamespace)
     localStorageNamespace = Platform::current()->createLocalStorageNamespace();
   return StorageArea::create(
-      wrapUnique(localStorageNamespace->createStorageArea(origin->toString())),
+      wrapUnique(
+          localStorageNamespace->createStorageArea(WebSecurityOrigin(origin))),

[esprehn, 2016/10/08 03:36:23]

Does WebSecurityOrigin not implicitly convert? I think you can just pass origin

[Charlie Harrison, 2016/10/09 02:40:11]

No it doesn't implicitly convert. My C++ foo isn't strong enough to know why
exactly:
"reference to type 'const blink::WebSecurityOrigin' could not bind to an lvalue
of type 'blink::SecurityOrigin *'"

We do have a non-explicit constructor that takes a PassRefPtr<SecurityOrigin>...

       LocalStorage);
 }
 
 StorageArea* StorageNamespace::storageArea(SecurityOrigin* origin) {
   return StorageArea::create(
-      wrapUnique(m_webStorageNamespace->createStorageArea(origin->toString())),
+      wrapUnique(
+          m_webStorageNamespace->createStorageArea(WebSecurityOrigin(origin))),
       SessionStorage);
 }