Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1974)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2382973002: Convert WebSecurityOrigin -> GURL without re-parsing the url (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 018ceadd69b3f87b97c45c20cb4c8fce1574ac5f..dc4b3f62043a91d776995bc9a18a33d552cad92a 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -198,6 +198,7 @@
#include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
#include "third_party/WebKit/public/web/WebView.h"
#include "third_party/WebKit/public/web/WebWidget.h"
+#include "url/origin.h"
#include "url/url_constants.h"
#include "url/url_util.h"
@@ -2602,11 +2603,10 @@ blink::WebPlugin* RenderFrameImpl::createPlugin(
WebPluginInfo info;
std::string mime_type;
bool found = false;
- WebString top_origin = frame->top()->getSecurityOrigin().toString();
- Send(new FrameHostMsg_GetPluginInfo(routing_id_, params.url,
- blink::WebStringToGURL(top_origin),
- params.mimeType.utf8(), &found, &info,
- &mime_type));
+ Send(new FrameHostMsg_GetPluginInfo(
+ routing_id_, params.url,
+ url::Origin(frame->top()->getSecurityOrigin()).GetURL(),
+ params.mimeType.utf8(), &found, &info, &mime_type));
if (!found)
return NULL;
@@ -2650,8 +2650,8 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
&GetSharedMainThreadContext3D,
RenderThreadImpl::current()->SharedMainThreadContextProvider());
- scoped_refptr<media::MediaLog> media_log(new RenderMediaLog(
- blink::WebStringToGURL(frame_->getSecurityOrigin().toString())));
+ scoped_refptr<media::MediaLog> media_log(
+ new RenderMediaLog(url::Origin(frame_->getSecurityOrigin()).GetURL()));
#if defined(OS_ANDROID)
if (UseWebMediaPlayerImpl(url) && !media_surface_manager_)
@@ -4314,10 +4314,8 @@ void RenderFrameImpl::requestStorageQuota(
return;
}
ChildThreadImpl::current()->quota_dispatcher()->RequestStorageQuota(
- render_view_->GetRoutingID(),
- blink::WebStringToGURL(origin.toString()),
- static_cast<storage::StorageType>(type),
- requested_size,
+ render_view_->GetRoutingID(), url::Origin(origin).GetURL(),
+ static_cast<storage::StorageType>(type), requested_size,
QuotaDispatcher::CreateWebStorageQuotaCallbacksWrapper(callbacks));
}
@@ -4400,8 +4398,7 @@ bool RenderFrameImpl::allowWebGL(bool default_value) {
bool blocked = true;
Send(new FrameHostMsg_Are3DAPIsBlocked(
- routing_id_,
- blink::WebStringToGURL(frame_->top()->getSecurityOrigin().toString()),
+ routing_id_, url::Origin(frame_->top()->getSecurityOrigin()).GetURL(),
THREE_D_API_TYPE_WEBGL, &blocked));
return !blocked;
}
@@ -5841,7 +5838,7 @@ WebMediaPlayer* RenderFrameImpl::CreateWebMediaPlayerForMediaStream(
return new WebMediaPlayerMS(
frame_, client, GetWebMediaPlayerDelegate()->AsWeakPtr(),
- new RenderMediaLog(blink::WebStringToGURL(security_origin.toString())),
+ new RenderMediaLog(url::Origin(security_origin).GetURL()),
CreateRendererFactory(), compositor_task_runner,
render_thread->GetMediaThreadTaskRunner(),
render_thread->GetWorkerTaskRunner(), render_thread->GetGpuFactories(),

Powered by Google App Engine
This is Rietveld 408576698